Closed Bug 764867 Opened 10 years ago Closed 10 years ago

Android Sync branding should match installed Fennec branding

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

All
Android
defect

Tracking

(firefox15 affected, firefox16 fixed, firefox17 verified, fennec+)

VERIFIED FIXED
mozilla17
Tracking Status
firefox15 --- affected
firefox16 --- fixed
firefox17 --- verified
fennec + ---

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa+])

Attachments

(4 files)

From IRC:

09:12 AaronMT: [08:20:18] Just noticed Sync setup is hard-coded with Fx branding; that expected?
09:18 nalexander: AaronMT: elaborate?  I'm looking into multiple Fennecs and Sync right now and might be able to look into it.
09:20 AaronMT: nalexander: Dont have the phone on me atm; was in Nightly, saw Firefox logo/string branding

We should be careful to use the Fx logos and strings where appropriate.
The only string references I see to Firefox are in the noun phrase "Firefox Sync" (which should not match the product name) and references to "your desktop Firefox".

Iconography probably isn't adapted correctly, though. Sometimes that's fine (Ian recently provided a Firefox logo to use for Send Tab).
Priority: -- → P2
Device tab page

(Honestly, I only own one Galaxy Nexus!)
tracking-fennec: --- → ?
Comment on attachment 638909 [details]
Nightly (07/03) - Screenshot

Yeah, this is a known issue (with no ticket, AFAIK).  You've set up this account on your Galaxy Nexus several times; each time, we choose a random client GUID to identify the device, and they're never purged.  We could address this in a bunch of different ways.
(In reply to Nick Alexander :nalexander from comment #4)

> Yeah, this is a known issue (with no ticket, AFAIK).

Filed Bug 770785. Let's keep this bug on-topic.
Note that this was the 'constant' icon that Ian provided in Bug 742478. I jus' do what I'm told, UI-wise :)
Depends on: 742478
Priority: P2 → P1
Attached are channel-specific icons that can be used in these menus.
Thanks, Ian!
tracking-fennec: ? → +
rnewman: can you explain why you added icons to 

$(TOPDIR)/res/drawable-*/

in

https://hg.mozilla.org/integration/mozilla-inbound/rev/4297a8802cd5
(In reply to Nick Alexander :nalexander from comment #9)
> rnewman: can you explain why you added icons to 
> 
> $(TOPDIR)/res/drawable-*/

Accidental during commit. Kill them, r=me.
> Accidental during commit. Kill them, r=me.

Killed them in https://hg.mozilla.org/integration/mozilla-inbound/rev/78dce09ed250.
Blocks: 772645
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e71d9e5e868
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
Steps to verify:

All Firefox Sync logos used to be "official" Firefox logo, and should now use whatever the installed Firefox logo is (probably Nightly).  To check 3 places that use the logo in different ways:

1. go to Android > Settings > Accounts & sync > Add Account.
2. verify that "Firefox Sync" has Firefox branded logo (probably Nightly's logo).
3. select "Firefox Sync".
4. verify that "Add a Firefox Sync Account" page has Firefox branded logo (again, probably Nightly's logo).
5. pair device to existing Sync account.
6. from within Fennec, share a page.
7. verify that "Firefox Sync" Send Tab activity has Firefox branded logo.
Whiteboard: [qa+]
Question: should the "Set up Firefox Sync" button still use the "Gray Rotating Arrows" icon?  We've moved Sync away from the arrows (to the Firefox channel logo) in order to support multiple Apps, so these arrows don't appear elsewhere on the device.  They do appear on all desktops.
(In reply to Nick Alexander :nalexander from comment #14)
> Question: should the "Set up Firefox Sync" button still use the "Gray
> Rotating Arrows" icon?  We've moved Sync away from the arrows (to the
> Firefox channel logo) in order to support multiple Apps, so these arrows
> don't appear elsewhere on the device.  They do appear on all desktops.

I believe so: desktop parity, in-product branding versus out-of-product.
https://hg.mozilla.org/mozilla-central/rev/2e71d9e5e868
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Beta/Aurora uplift?
Status: RESOLVED → VERIFIED
Makefile changes, so I'm inclined to uplift to as few places as possible. Aurora is probably quite feasible.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  History!

User impact if declined: 
  Confused branding between channels. Usability impact when multiple Fennec Sync support lands.

Testing completed (on m-c, etc.): 
  Verified on m-c.

Risk to taking this patch (and alternatives if risky): 
  Minimal: any problems should be immediately and blindingly obvious.

String or UUID changes made by this patch: 
  None.
Attachment #647551 - Flags: review+
Attachment #647551 - Flags: approval-mozilla-aurora?
(In reply to Richard Newman [:rnewman] from comment #19)
> Created attachment 647551 [details] [diff] [review]
> Proposed patch for Aurora. v1

Flyby: looks good to me.
(In reply to Nick Alexander :nalexander from comment #20)

> Flyby: looks good to me.

I sure hope so; it's the code you landed :)
(In reply to Richard Newman [:rnewman] from comment #21)
> (In reply to Nick Alexander :nalexander from comment #20)
> 
> > Flyby: looks good to me.
> 
> I sure hope so; it's the code you landed :)

Ah, but I wanted to be sure we didn't drop the Sync icon deletions, and that we maintained the Makefile changes.  Of coures, the original patch might apply cleanly :)
Comment on attachment 647551 [details] [diff] [review]
Proposed patch for Aurora. v1

Since changes will be blindingly obvious, approved for Aurora.
Attachment #647551 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.