742644 - IRC's username empty text ("and server") in the Chat Account Wizard is confusing

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Kami]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:13.0) Gecko/20120327 Firefox/13.0a2
Build ID: 20120327115436

Steps to reproduce:

Creating IRC connect, I am on username page


Actual results:

When I selected Server textfield while Username is empty, Username field shows grey "and server" text.


Expected results:

Probably we should no do anything or write "Enter username here" or something similar.

Comment 1

[Florian Quèze [:florian]]

Attachment: Screenshot

Comment 2

[Florian Quèze [:florian]]

This is because the text used for the username empty text is the same as the text used for what's in parentheses after "username" in the sentence above.
Blake, should we just remove that "and server" text completely for IRC accounts?

Comment 3

[Patrick Cloke [:clokep]]

(In reply to Florian Quèze from comment #2)
> Blake, should we just remove that "and server" text completely for IRC
> accounts?
Please do, it doesn't make any sense. If we'd like to set the empty text, we should use a different string.

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch

Let's revert this change (https://hg.instantbird.org/instantbird/rev/e142bb7beb1a) that we added during the ui-review of IM-in-Tb's main patch but turns out to be even more confusing than what it was trying to improve.

ui-r=bwinton over Vidyo

Note: We started discussing a better long term solution at https://bugzilla.instantbird.org/show_bug.cgi?id=1426#c6

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 622381 [details] [diff] [review]
Patch

This looks fine; I definitely think it's less confusing without this.

(Uhh...I'm noticing now it also refers to GTalk? Poor review last time I guess. :()

Comment 6

[Florian Quèze [:florian]]

http://hg.mozilla.org/comm-central/rev/cf8f349b1fe6