742674 - Instant messenger status window dimensions (width and height) too small, text gets cropped

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird daily 2012-04-04, Windows XP SP 3 32-bit

The dimensions (width & height) of the instant messenger status window are too small. Directly after creating an IRC connection and joining it, "Connected for about 1 minute" will get cropped to "Connected for about 1 minute"

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

During the review of the main IM-in-Tb patch, I was asked to convert the default size of that window from a value in px to a value in em (bug 714733 comment 87), and it seems I messed up the conversion between these units (it seems that by default 1em is about 11px).

Comment 2

[Florian Quèze [:florian]]

Attachment: Screenshot of the new default size with attachment 621583 applied

Adding a screenshot to help with the ui-review.

The dimensions of that dialog are persisted, so testing the default values requires either using a new profile, or nuking the localstore.rdf from the test profile.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 621583 [details] [diff] [review]
Patch

Yeah, this looks a lot better.  ui-r=me!

Thanks,
Blake.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 621583 [details] [diff] [review]
Patch

Not totally sure we need the id change in theory, but lets do it anyway to make sure locales are fully aware.

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/3a60b7910733