743158 - Awesome Screen should select/deselect URL text on address bar focus on change

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Luke Wagner [:luke]]

STR:
 0. Open Fennec and go to any site
 1. Tap the location bar to pull up the awesome-bar screen
    (the whole URL is selected now so entering text will replace it which is good)
 2. Pan the awesome-bar list
    (this makes the keyboard go away, but the URL text is still all selected)
 3. Touch the URL text again to pull up the keyboard again.

Result: because the text is already selected, when I touch it in (3), the URL text becomes unselected (I get an insertion cursor).  Now, if I wanted to type something in (probably what I wanted to do as I just selected the URL bar) I need to first "select all".

Expected result: when I pan the awesome-bar list and the keyboard goes away (step 2), the text should be unselected (the selection is almost meaningless now that the keyboard is gone anyhow).  That way, when I touch the URL bar again (to bring up the keyboard) it will all be selected again and I am ready to immediately enter my query.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

related to bug 717392

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

noming for release?

Comment 3

[Luke Wagner [:luke]]

Renom'ing since, after more consideration, this seems to be a straight-up bug: when the keyboard goes away, the text selection should as well.

A minor variation with same underlying bug:
 1. go to any site
 2. tap the location bar
 3. tap the bookmarks tab
The text is still selected despite the keyboard going away so attempting to enter text will have the same problem.

Comment 4

[Johnathan Nightingale [:johnath]]

We've got our endgame hats on - worth fixing, but not a blocker.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

QA - Are the STR still valid?

Comment 6

[Luke Wagner [:luke]]

I can still repro comment 0 with the current nightly (comment 3 seems to have gone away).

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Both STRs are valid (from comment 0 and comment 3), though I believe that these are as designed?

The reason I state this is because we would expect that if people wanted to change the whole link they would have done so or selected a link from the list after panning.  If they touch the url a second time, they would be changing the URL to correct the mistake that they had...  I could be mistaken.  

including madhava and ibarlow.

Comment 8

[Luke Wagner [:luke]]

The key problem that makes think that this a bug is that the keyboard goes away while the text stays selected.  If the keyboard didn't go away, you could just start typing (and the existing text would be replaced).  Basically, I would guess that a UI invariant would be:

  text is selected iff keyboard is visible

Perhaps I'm missing something though?

Comment 9

[Chris Peterson [:cpeterson]]

This bug is very annoying.

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Take focus away from awesome bar when accessing awesome screen lists (v1)

This patch fixes the bug by giving the lists focus and taking focus away from the awesome bar. Because the awesome bar already has the selectAllOnFocus attribute, everything will be selected when you refocus it.

Comment 11

[Wesley Johnston (:wesj)]

Comment on attachment 741574 [details] [diff] [review]
Take focus away from awesome bar when accessing awesome screen lists (v1)

Review of attachment 741574 [details] [diff] [review]:
-----------------------------------------------------------------

I bet this was the way it was for devices with hardware keyboards. i.e. you could pan the list there without unfocusing the urlbar. Are we ok breaking that?

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Wesley Johnston (:wesj) from comment #11)
> Comment on attachment 741574 [details] [diff] [review]
> Take focus away from awesome bar when accessing awesome screen lists (v1)
> 
> Review of attachment 741574 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I bet this was the way it was for devices with hardware keyboards. i.e. you
> could pan the list there without unfocusing the urlbar. Are we ok breaking
> that?

I think if the user already focused away from the awesome bar, it's logical to tap the awesome bar again if they want to type in it again (even if they're using a hardware keyboard).

Also it's pretty obvious when focus is moved away, because the awesome bar will lose its focus highlight.

Comment 14

[Wesley Johnston (:wesj)]

Comment on attachment 741574 [details] [diff] [review]
Take focus away from awesome bar when accessing awesome screen lists (v1)

Review of attachment 741574 [details] [diff] [review]:
-----------------------------------------------------------------

I bet this was the way it was for devices with hardware keyboards. i.e. you could pan the list there without unfocusing the urlbar. I'm fine breaking that, but you might want to run the change by UX.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc11cd6a518a

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc11cd6a518a

Comment 17

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
-build: Firefox for Android 23.0a2 (2013-05-16)
-device: Samsung Galaxy Tab
-OS: Android 4.0.4