Closed
Bug 880650
Opened 12 years ago
Closed 12 years ago
VKB is not dismissed when switching awesomebar sections after adding a page to reading list
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox23 affected, firefox24 verified)
VERIFIED
FIXED
Firefox 24
People
(Reporter: TeoVermesan, Assigned: jchen)
References
Details
(Keywords: regression, reproducible)
Attachments
(3 files)
6.94 KB,
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
1.09 KB,
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
1.80 KB,
patch
|
AdrianT
:
review+
|
Details | Diff | Splinter Review |
Build: Firefox for Android 24.0a1 (2013-06-06)
Device: LG Nexus 4
OS: Android 4.2.2
Steps to Reproduce:
1. Open Firefox
2. Go to nytimes.com and open any article
3. Tap on the Reader Mode icon on URL Bar
4. Tap on Add to Reading List button
5. Tap on Reading List button
6. Change between Bookmarks/Top Sites/History sections.
Expected:
- The VKB is dismissed when taping the History/Top Sites section.
Actual:
- The VKB is not dismissed
Comment 1•12 years ago
|
||
Looks like it was caused by bug 743158 ...
Updated•12 years ago
|
Keywords: regression,
reproducible
Assignee | ||
Comment 2•12 years ago
|
||
I don't think the VKB should pop up at all if we are showing the reading list. But I was unable to track down which code is showing the VKB. Saving to look at later.
Assignee: nobody → nchen
Comment 3•12 years ago
|
||
I read this all as,
Behaviour prior to bug 732158
Situation #1
Tap into Awesombar
Title is Focused
Keyboard is Open
Pan Left
Title is Focused
Keyboard is Closed
Situation #2
Tap in Reading List
No title to focus
Keyboard is Open
Pan Left
No title to focus
Keyboard is Closed
After bug 732158
Situation #1
Tap into Awesomebar
Title is Focused
Keyboard is Open
Pan Left
Title LOSES Focus <--- The change they wanted
Keyboard is closed
Situation #2
Tap into Reading List
No title to focus
Keyboard is Open
Pan Left
No title to focus
Key Stays Open <--- A change they didn't ask for and this bug is about
Assignee | ||
Comment 4•12 years ago
|
||
That's correct. But in addition to that, I was arguing that maybe the keyboard should not be open at all when showing the reading list, so the final scenario would become,
Situation #2
Tap into Reading List
No title to focus
Keyboard is Closed
Pan Left
No title to focus
Key Stays Closed
Assignee | ||
Comment 5•12 years ago
|
||
We now have saner focusing/defocusing of the URL bar, so a lot of the custom show/hide VKB calls can go away. We show the keyboard when URL bar gets focus and not show the keyboard when it loses focus.
Attachment #761170 -
Flags: review?(cpeterson)
Comment 6•12 years ago
|
||
Comment on attachment 761170 [details] [diff] [review]
Bug 880650 - Clean up hiding/showing VKB in the awesome screen; r=
Review of attachment 761170 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #761170 -
Flags: review?(cpeterson) → review+
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 7•12 years ago
|
||
Keywords: checkin-needed
Comment 8•12 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f80387acd7 - everything with robo in the jobname was unhappy,
https://tbpl.mozilla.org/php/getParsedLog.php?id=24039251&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=24039580&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=24038862&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=24039282&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=24039492&tree=Mozilla-Inbound
Assignee | ||
Comment 9•12 years ago
|
||
Looks like I should have kept the selectAll call
Attachment #762317 -
Flags: review?(cpeterson)
Comment 10•12 years ago
|
||
Comment on attachment 762317 [details] [diff] [review]
Add selectAll call to URL bar initialization (v1)
Review of attachment 762317 [details] [diff] [review]:
-----------------------------------------------------------------
oops! LGTM.
Attachment #762317 -
Flags: review?(cpeterson) → review+
Assignee | ||
Comment 11•12 years ago
|
||
With the patches in this bug, the VKB no longer appears when going back from the Edit Bookmark dialog, so we no longer need to toggle the VKB. In fact, testBookmarksTab now fails when we do toggle the VKB.
Attachment #763716 -
Flags: review?(adrian.tamas)
Comment 12•12 years ago
|
||
Comment on attachment 763716 [details] [diff] [review]
Don't try to dismiss VKB during testBookmarksTab (v1)
Review of attachment 763716 [details] [diff] [review]:
-----------------------------------------------------------------
The test looks good and passes locally on the Asus EEE Transformer (Android 4.0.4) and the HTC Desire Z (Android 2.3)
Attachment #763716 -
Flags: review?(adrian.tamas) → review+
Assignee | ||
Comment 13•12 years ago
|
||
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a5b205aacce1
https://hg.mozilla.org/mozilla-central/rev/38f7c6ceb5d6
https://hg.mozilla.org/mozilla-central/rev/63a1892e5298
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
status-firefox24:
--- → verified
Reporter | ||
Updated•12 years ago
|
status-firefox23:
--- → affected
Comment 15•12 years ago
|
||
Looks like 23 is affected according to Teodora, uplift?
Flags: needinfo?(nchen)
Assignee | ||
Comment 16•12 years ago
|
||
Need to uplift Bug 877659 first.
Depends on: 877659
Flags: needinfo?(nchen)
Comment 17•12 years ago
|
||
Mentioned that in that bug.
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•