743227 - "Always show" does not display the popoups until a page reload

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: Show vs Always Show logs

Fennec/14.0a1 2012-04-06
Device: Motorola Droid 2(Android 2.3)

Steps to reproduce:
1. Load http://www.popuptest.com/popuptest1.html.
2. When asked choose show and wait for the popups to trigger.
3. Close all popups and reload the page.
4. Choose "Always Show".

Expected results:
The popups are triggered.

Actual results:
The popups are triggered only after a page reload.

Comment 1

[:Margaret Leibovic]

This looks like it probably never worked...

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3515

This is easy to fix.

I also found that desktop Firefox doesn't immediately show popups when you select "Allow", but the UI is different there (you can see a list of popup windows you might want to open), so I don't think we need to be consistent here.

Comment 2

[:Margaret Leibovic]

Attachment: patch

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 612914 [details] [diff] [review]
patch

Nice!  Now could you also fix the same bug in desktop Firefox (bug 731865)? :)

Comment 4

[:Margaret Leibovic]

Attachment: patch

I actually just found that we need to set the permission before opening the other popups, since they can come to the foreground, and allowPopupsForSite uses BrowserApp.selectedBrowser.currentURI to set the permission.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90c1118bce0a

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/90c1118bce0a

Comment 7

[Paul Feher]

Verified fixed on: 
Nightly Fennec 14.0a2 (2012-04-29)
Nightly Fennec 15.0a1 (2012-04-29)
Device: HTC Desire Z
OS: Android 2.3.3