Closed Bug 743703 Opened 13 years ago Closed 11 years ago

Log WebRTC debugs to NSPR logs

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Whiteboard: [WebRTC], [blocking-webrtc-])

Attachments

(2 files, 4 obsolete files)

patch to mirror logs from webrtc logging to NSPR logging (but not TRACE logs)
11.28 KB, patch
ehugg
: feedback+
Details | Diff | Splinter Review
allow mirroring of trace logs to NSPR; fix backwards lazy allocation defines
10.90 KB, patch
pkerr
: review+
Details | Diff | Splinter Review
We'd like to log all debugs from WebRTC to mozilla's logging infrastructure.
Blocks: 688178
appears to work, still WIP. setenv NSPR_LOG_FILE /tmp/foo; setenv NSPR_LOG_MODULES webrtc:5
Attachment #613787 - Attachment is obsolete: true
Attachment #614152 - Attachment is obsolete: true
Attachment #614251 - Attachment is obsolete: true
Comment on attachment 614274 [details] [diff] [review] patch to mirror logs from webrtc logging to NSPR logging (but not TRACE logs) This patch works on both alder trunk and on paris_demo branches
Comment on attachment 614274 [details] [diff] [review] patch to mirror logs from webrtc logging to NSPR logging (but not TRACE logs) I expect further work on logging, but this is a primary step towards unifying logging.
Attachment #614274 - Flags: feedback?(ethanhugg)
Assignee: nobody → rjesup
Comment on attachment 614274 [details] [diff] [review] patch to mirror logs from webrtc logging to NSPR logging (but not TRACE logs) I assume we should follow this pattern with the signaling logs (CSFLog.cpp).
Attachment #614274 - Flags: feedback?(ethanhugg) → feedback+
QA Contact: jsmith
Whiteboard: [WebRTC], [blocking-webrtc-]
This was for the libjingle logging.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Turns out the lazy allocation setting got inverted somewhere, so we were wasting 4MB of memory as well
Comment on attachment 8428396 [details] [diff] [review] allow mirroring of trace logs to NSPR; fix backwards lazy allocation defines Allows mirrors of webrtc.org trace logs to NSPR logging. NOTE: this can have a negative performance impact (especially if going to stderr), even though it's off the realtime threads, because of the possible volume of logging and NSPR logs per-line. Set WEBRTC_TRACE_FILE to 'nspr' and it will mirror them. It might be better to default WEBRTC_TRACE_FILE to 'nspr' instead of WebRTC.log...
Attachment #8428396 - Flags: review?(pkerr)
Attachment #8428396 - Attachment is obsolete: true
Attachment #8428396 - Flags: review?(pkerr)
Attachment #8428402 - Flags: review?(pkerr)
Attachment #8428402 - Flags: review?(pkerr) → review+
https://hg.mozilla.org/mozilla-central/rev/d94346125453
Status: REOPENED → RESOLVED
Closed: 13 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: