Last Comment Bug 743817 - make font inflation reftests live in reftest harness rather than mochitest
: make font inflation reftests live in reftest harness rather than mochitest
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: P4 normal (vote)
: mozilla14
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on: 743105 780581
Blocks: 706193
  Show dependency treegraph
 
Reported: 2012-04-09 14:11 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2012-08-06 04:29 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (41.45 KB, patch)
2012-04-09 18:28 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
jaywir3: review+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-04-09 14:11:32 PDT
To make testing bug 706193 easier, I want to convert the font inflation reftests to use the reftest harness rather than the mochitest harness.  Bug 743105 allows doing this.

This makes it easy to make the existing tests, written on the assumption of not having bug 706193, run with that fix disabled, but to make new tests that test that fix and run with it enabled.

Note also that I ran into bug 743805 while doing this, and had to modify a few of the tests (for which we must have been cutting off the scrollbars when running in the mochitest harness, perhaps?).
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-04-09 14:19:42 PDT
Also noticed bug 706889 comment 24 while checking that I did this correctly.
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-04-09 18:28:58 PDT
Created attachment 613462 [details] [diff] [review]
patch
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-04-10 10:58:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce4cfbc091dc
Comment 4 Matt Brubeck (:mbrubeck) 2012-04-11 09:05:53 PDT
https://hg.mozilla.org/mozilla-central/rev/ce4cfbc091dc

Note You need to log in before you can comment on or make changes to this bug.