743933 - [b2g-bluetooth] Update B2G Bluetooth API to ICS code

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

The bluetooth DBus calls are currently based on gingerbread's bluetooth API. Once we're completely off gingerbread, we should update our code to work with the newer DBus/bluez calls.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Current list:

- Add WAKEUP flags for dbus wakeup signals
- Change dbus_watch_get_fd to dbus_watch_get_unix_fd

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Nice to have to get rid of some deprecation warnings, but not a blocker for shipping, especially since we've bounced back and forth between gb and ics so much.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Update DBus features to ICS

No feature updates in this, mostly warning fixes and the ability to attach to wakeup (which might have some nice uses in V2)

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v2) - Update DBus features to ICS

Doing a bit of debug message cleanup while we're at it.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 661890 [details] [diff] [review]
Patch 1 (v2) - Update DBus features to ICS

Review of attachment 661890 [details] [diff] [review]:
-----------------------------------------------------------------

r+ after nits are fixed.

::: ipc/dbus/DBusThread.cpp
@@ +276,5 @@
>    aDbt->mWatchData.RemoveElementAt(index);
>  }
>  
> +static
> +void DBusWakeup(void* aData) {

Nit: brace should be at a separate line.

@@ +279,5 @@
> +static
> +void DBusWakeup(void* aData) {
> +  DBusThread *dbt = (DBusThread *)aData;
> +  char control = DBUS_EVENT_LOOP_WAKEUP;
> +  if(write(dbt->mControlFdW.get(), &control, sizeof(char)) < 0) {

Nit: needs a blank behind "if"

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/176b61afc41d

Comment 7

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/176b61afc41d