784255 - [b2g-bluetooth] devicefound event does not come up correctly

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

I tried to use latest code base to discovery devices nearby but failed. It's because GetProperty() in ParseProperties() returned false, so that aValue = props would not be executed and aValue would have no value. The root cause is there was a 'Type' property in devicefound event, but we were unable to recognize it because it didn't exist in sDeviceProperties. We have to update sDeviceProperties & sAdapterProperties to the same value as in Android ICS[1].

[1] See android_bluetooth_common.cpp for more information.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Forgot to mention, the issue happened on otoro.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: v1: Add property 'Type' to device and adapter property name list

Type is a newly added property of BlueZ (in ICS). Old version BlueZ won't be affected because we didn't delete or modify any existing properties.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 653649 [details] [diff] [review]
v1: Add property 'Type' to device and adapter property name list

Review of attachment 653649 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Linked to bug 743933, which is other ICS dbus/bluez changes. I can't even start on that until the arm7 gb try target is gone though, so mainly just putting this here to note.

Comment 4

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a8fdb08193

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f9a8fdb08193