Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[b2g-bluetooth] devicefound event does not come up correctly

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ericchou, Assigned: ericchou)

Tracking

unspecified
mozilla17
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I tried to use latest code base to discovery devices nearby but failed. It's because GetProperty() in ParseProperties() returned false, so that aValue = props would not be executed and aValue would have no value. The root cause is there was a 'Type' property in devicefound event, but we were unable to recognize it because it didn't exist in sDeviceProperties. We have to update sDeviceProperties & sAdapterProperties to the same value as in Android ICS[1].

[1] See android_bluetooth_common.cpp for more information.
(Assignee)

Updated

5 years ago
Assignee: nobody → echou
(Assignee)

Comment 1

5 years ago
Forgot to mention, the issue happened on otoro.
(Assignee)

Comment 2

5 years ago
Created attachment 653649 [details] [diff] [review]
v1: Add property 'Type' to device and adapter property name list

Type is a newly added property of BlueZ (in ICS). Old version BlueZ won't be affected because we didn't delete or modify any existing properties.
Attachment #653649 - Flags: review?(kyle)
Blocks: 743933
Comment on attachment 653649 [details] [diff] [review]
v1: Add property 'Type' to device and adapter property name list

Review of attachment 653649 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Linked to bug 743933, which is other ICS dbus/bluez changes. I can't even start on that until the arm7 gb try target is gone though, so mainly just putting this here to note.
Attachment #653649 - Flags: review?(kyle) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a8fdb08193

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f9a8fdb08193
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Blocks: 727618
You need to log in before you can comment on or make changes to this bug.