74413 - Bug in nsViewManager::UpdateAllCoveringWidgets

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P1)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

While looking at some testcases, I found a bug where we fail to invalidate views 
correctly in some cases. Basically the code incorrectly assumes that a child 
widget completely covers the invalid region and therefore neglects to repaint 
the parent widget when it should. I will attach a patch.

The testcase http://bugzilla.mozilla.org/showattachment.cgi?attach_id=6234 shows 
this; scrolling the gray DIV will not update the scrollbar thumb area correctly. 
(In particular, the area extending above the blue DIV is not updated correctly.)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: The fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK ... now I'm ready for approval.

Comment 3

[Kevin McCluskey (gone)]

r=[e-mail]

Comment 4

[Marc Attinasi]

sr=attinasi

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Ta, waiting for the tree to open

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in.

Comment 7

[Chris Petersen]

Marking verified in the May 24th build.