744189 - Can't open bookmarks from the Firefox button

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

When I click a bookmark from the Firefox button's bookmarks submenu, the bookmark doesn't open, and I get the following error logged in my error console:

Timestamp: 4/10/2012 4:29:23 PM
Error: aView is undefined
Source File: resource:///modules/PlacesUIUtils.jsm
Line: 655

This is happening for me in safe mode on the most recent win32 Nightly build.
I'm not sure offhand when this started to not work, as I rarely use the Firefox button's bookmarks menu.

Comment 1

[Alice0775 White]

Regression window(m-c)
works:
http://hg.mozilla.org/mozilla-central/rev/9ca66ce2672f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120409 Firefox/14.0a1 ID:20120409031240
fails:
http://hg.mozilla.org/mozilla-central/rev/7227004c8893
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120409 Firefox/14.0a1 ID:20120409100742
pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9ca66ce2672f&tochange=7227004c8893


Regression window(m-c)
works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4ea78fe84b7c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120406 Firefox/14.0a1 ID:20120406045845
fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/690e77288e98
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120406 Firefox/14.0a1 ID:20120406064443
pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4ea78fe84b7c&tochange=690e77288e98

Regresed by:
690e77288e98	Asaf Romano — Bug 739451 - Don't rely on XPConnect-magic for getting the owner window of a places view (Required for compartment-per-global work). r=mak

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I can reproduce this bug too. Additionally, if IE View (1.5.0) is installed (and enabled), bookmark toolbar's bookmark items don't work too. In other words, you can use bookmark toolbar without IE View.

Comment 3

[Girish Sharma [:Optimizer]]

I can reproduce this bug too on the latest Nightly. Bookmarks work fine from toolbar of bookmarks button on bookmarks toolbar but not from Firefox Menu.

Comment 4

[Asaf Romano (gone)]

Attachment: Untested fix

Comment 5

[Frederic Bezies]

You can change OS to all. Seeing this on Linux 64 bits. Kinda annoying bug.

Comment 6

[Spencer Selander [greenknight]]

For me, it's only middle-click that doesn't work - left-click and right-click work as normal.

I use Ie View Lite, no issues with the Bookmarks Toolbar.

Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120410 Firefox/14.0a1 ID:20120410075652

Comment 7

[Spencer Selander [greenknight]]

Now only right-click is working.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 613890 [details] [diff] [review]
Untested fix

Review of attachment 613890 [details] [diff] [review]:
-----------------------------------------------------------------

tested working and makes sense.

Comment 10

[:Paolo Amadini]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9413f184e70e

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/9413f184e70e

Comment 14

[Klaus P. Kuhlemann]

This fix don't work for me in the latest win64 2012-04-21 nightly or 2012-04-22 mozilla-central tinderbox builds. Clicking left on the bookmark entry dont't open a website, clicking right-open works.

Comment 15

[Paul Roub]

For those seeing the issue with IE View 1.5 and FF 14 alpha, there's an IE View build at https://github.com/downloads/paulroub/ieview/ieview.xpi that addresses the issue; it's the same issue addressed by the patch attached to this bug, but IE View's fault in this case.  Feedback is welcome before I push the fix into a public release.

Comment 16

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Klaus P. Kuhlemann from comment #14)
> This fix don't work for me in the latest win64 2012-04-21 nightly or
> 2012-04-22 mozilla-central tinderbox builds. Clicking left on the bookmark
> entry dont't open a website, clicking right-open works.

Does safe mode help? You may have a prolem with an add-on.
http://support.mozilla.org/kb/Safe+Mode

Comment 17

[Klaus P. Kuhlemann]

(In reply to Paul Roub from comment #15)
IE View 1.5, which I used often as web-designer, has been the problem. Uninstalling that resolves the bug. Your 1.5.02 build works for me perfectly. I suggest that you'll release the patch.