delete CPP_PROG_LINK, purify/quantify targets

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Bug 743988 deleted two major users of CPP_PROG_LINK; the remaining ones are the purify and quantify targets.  I'm guessing those are not used much in this day and age, so they can be nuked.
(Assignee)

Comment 1

5 years ago
Created attachment 614871 [details] [diff] [review]
delete purify target

Let's do this in pieces.  We'll start by deleting the purify target.

bsmedberg, I see pure.h and pure_api.c in xpcom/base/; should those be deleted along with this support?
Attachment #614871 - Flags: review?(ted.mielczarek)
Attachment #614871 - Flags: feedback?(benjamin)
(Assignee)

Comment 2

5 years ago
Created attachment 614872 [details] [diff] [review]
delete quantify target and related support

The quantify support is a little more extensive, but nothing that complex.
Attachment #614872 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

5 years ago
Created attachment 614874 [details] [diff] [review]
delete CPP_PROG_LINK

Remove scattered usages of CPP_PROG_LINK and its setting from rules.mk.

A bunch of places were forcing CPP_PROG_LINK to be on; maybe those should get removed even if the rest of the patches don't go in.
Attachment #614874 - Flags: review?(ted.mielczarek)
Attachment #614871 - Flags: review?(ted.mielczarek) → review+
Attachment #614871 - Flags: feedback?(benjamin)
Attachment #614874 - Flags: review?(ted.mielczarek) → review+
Attachment #614872 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → nfroyd
(Assignee)

Comment 4

5 years ago
Committed with small tweaks to js/src/config/config.mk; local builds didn't pick up the bug, but try ones did.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1ccd09b3030
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d774bc0060
https://hg.mozilla.org/integration/mozilla-inbound/rev/e092bfd09576
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/c1ccd09b3030
https://hg.mozilla.org/mozilla-central/rev/67d774bc0060
https://hg.mozilla.org/mozilla-central/rev/e092bfd09576
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 754065
You need to log in before you can comment on or make changes to this bug.