Closed
Bug 744444
Opened 14 years ago
Closed 14 years ago
delete CPP_PROG_LINK, purify/quantify targets
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(3 files)
|
3.29 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
8.14 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
|
5.75 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Bug 743988 deleted two major users of CPP_PROG_LINK; the remaining ones are the purify and quantify targets. I'm guessing those are not used much in this day and age, so they can be nuked.
| Assignee | ||
Comment 1•14 years ago
|
||
Let's do this in pieces. We'll start by deleting the purify target.
bsmedberg, I see pure.h and pure_api.c in xpcom/base/; should those be deleted along with this support?
Attachment #614871 -
Flags: review?(ted.mielczarek)
Attachment #614871 -
Flags: feedback?(benjamin)
| Assignee | ||
Comment 2•14 years ago
|
||
The quantify support is a little more extensive, but nothing that complex.
Attachment #614872 -
Flags: review?(ted.mielczarek)
| Assignee | ||
Comment 3•14 years ago
|
||
Remove scattered usages of CPP_PROG_LINK and its setting from rules.mk.
A bunch of places were forcing CPP_PROG_LINK to be on; maybe those should get removed even if the rest of the patches don't go in.
Attachment #614874 -
Flags: review?(ted.mielczarek)
Updated•14 years ago
|
Attachment #614871 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Attachment #614871 -
Flags: feedback?(benjamin)
Updated•14 years ago
|
Attachment #614874 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Attachment #614872 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Assignee: nobody → nfroyd
| Assignee | ||
Comment 4•14 years ago
|
||
Committed with small tweaks to js/src/config/config.mk; local builds didn't pick up the bug, but try ones did.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1ccd09b3030
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d774bc0060
https://hg.mozilla.org/integration/mozilla-inbound/rev/e092bfd09576
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
Comment 5•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c1ccd09b3030
https://hg.mozilla.org/mozilla-central/rev/67d774bc0060
https://hg.mozilla.org/mozilla-central/rev/e092bfd09576
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•