744518 - Move Gesture:ShowPress code into touchstart event handler

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This is a spinoff from bug 741228, and the attached patch is wesj's patch from that bug that I already r+'d. It should land once bug 741247 is figured out, so that the touchstart event is consistently delivered to browser.js

Comment 1

[Wesley Johnston (:wesj)]

I'm planning to use this to fix bug 719276, which is a blocker, so I'm noming this one too.

Comment 2

[Wesley Johnston (:wesj)]

Whoops. Marked the wrong flag. I've been playing with this a bit today. I think we should take it.

I don't see highlights on the far side of nyt.com when zoomed out to page width, but we seem to find the right element. They also have trouble highlighting without this patch. I'm not sure if Gecko is just optimizing away the small change somewhere?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

This bug itself does not block, but if it fixes bug 719276 we'll take it right away.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/mozilla-central/rev/89e9b9213670

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 614094 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Forever
User impact if declined: Double taps can cause highlight to linger around forever
Testing completed (on m-c, etc.): Landed on mc 5-2
Risk to taking this patch (and alternatives if risky): Slightly risky
String changes made by this patch: none

Comment 6

[Alex Keybl [:akeybl]]

(In reply to Wesley Johnston (:wesj) from comment #5)
> Risk to taking this patch (and alternatives if risky): Slightly risky

This does not block Fennec 1.0. Please get a blocking-fennec1.0+ or approval from blassey/mfinkle before nominating for Aurora 14 uplift.

Comment 7

[Wesley Johnston (:wesj)]

This fixed a blocker (see comment 3). Renom I guess.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 614094 [details] [diff] [review]
Patch

(In reply to Mark Finkle (:mfinkle) from comment #3)
> This bug itself does not block, but if it fixes bug 719276 we'll take it
> right away.

Actually just saw this, and from https://bugzilla.mozilla.org/show_bug.cgi?id=719276#c15 it appears to be fixed. Approved for Aurora.

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1d3603c7289

Comment 11

[JP Rosevear [:jpr]]

Marking as fixed in 14.