744659 - [about:home][rtl] Use dir=auto in search box to change direction if query is RTL

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Tomer Cohen :tomer]

It is becoming more and more popular that sites use dir=auto or their own algorithm to check if an input field contain RTL text (Arabic, Hebrew, Farsi, Urdu etc.), and change the field text direction if needed. Since we already have this feature (bug 548206), why not make use of it in the brand new about:home page? 

Please note that Google already use similar implementation on their search site.

Comment 1

[Tomer Cohen :tomer]

Attachment: proposed change

Comment 2

[Marco Bonardo [:mak]]

The right bug that implemented dir="auto" for input fields is bug 662288, I think.
This could make sense, but I'm not that expert in rtl behavior, Ehsan may evaluate if this would be fine.

Comment 3

[(no longer active)]

Nope, dir=auto is bug 548206.  I'm fine with taking this patch, but please note that it will not have any effect until that bug is resolved.

Comment 4

[Marco Bonardo [:mak]]

(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> Nope, dir=auto is bug 548206.  I'm fine with taking this patch, but please
> note that it will not have any effect until that bug is resolved.

sorry, I was relying on https://bugzilla.mozilla.org/show_bug.cgi?id=548206#c38 that says it's already implemented on input and textarea.

Comment 5

[Simon Montagu :smontagu]

(In reply to Marco Bonardo [:mak] from comment #4)
> sorry, I was relying on
> https://bugzilla.mozilla.org/show_bug.cgi?id=548206#c38 that says it's
> already implemented on input and textarea.

Sorry, that's my fault -- see bug 548206 comment 40 for correction.

Comment 6

[(no longer active)]

Tomer, can you please submit a new patch which applies on trunk?

Comment 7

[Simon Montagu :smontagu]

Attachment: rebased patch

r=ehsan carried over

With trivial rebasing the patch applies and works. Is there any reason why I shouldn't just check it in?

Comment 8

[Marco Bonardo [:mak]]

I think you could just proceed.

Comment 9

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5469c3c3506d

Thanks, everyone!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5469c3c3506d