Closed Bug 744659 Opened 10 years ago Closed 9 years ago

[about:home][rtl] Use dir=auto in search box to change direction if query is RTL

Categories

(Firefox :: General, enhancement)

13 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: tomer, Assigned: tomer)

References

Details

(Whiteboard: [about-home])

Attachments

(1 file, 1 obsolete file)

It is becoming more and more popular that sites use dir=auto or their own algorithm to check if an input field contain RTL text (Arabic, Hebrew, Farsi, Urdu etc.), and change the field text direction if needed. Since we already have this feature (bug 548206), why not make use of it in the brand new about:home page? 

Please note that Google already use similar implementation on their search site.
Attached patch proposed change (obsolete) — Splinter Review
The right bug that implemented dir="auto" for input fields is bug 662288, I think.
This could make sense, but I'm not that expert in rtl behavior, Ehsan may evaluate if this would be fine.
Component: Untriaged → General
QA Contact: untriaged → general
Whiteboard: [about-home]
Attachment #614234 - Flags: review?(ehsan)
Nope, dir=auto is bug 548206.  I'm fine with taking this patch, but please note that it will not have any effect until that bug is resolved.
Attachment #614234 - Flags: review?(ehsan) → review+
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> Nope, dir=auto is bug 548206.  I'm fine with taking this patch, but please
> note that it will not have any effect until that bug is resolved.

sorry, I was relying on https://bugzilla.mozilla.org/show_bug.cgi?id=548206#c38 that says it's already implemented on input and textarea.
Depends on: DirAuto
(In reply to Marco Bonardo [:mak] from comment #4)
> sorry, I was relying on
> https://bugzilla.mozilla.org/show_bug.cgi?id=548206#c38 that says it's
> already implemented on input and textarea.

Sorry, that's my fault -- see bug 548206 comment 40 for correction.
Tomer, can you please submit a new patch which applies on trunk?
Attached patch rebased patchSplinter Review
r=ehsan carried over

With trivial rebasing the patch applies and works. Is there any reason why I shouldn't just check it in?
Attachment #614234 - Attachment is obsolete: true
Attachment #8345985 - Flags: review+
Flags: needinfo?(tomer.moz.bugs)
I think you could just proceed.
https://hg.mozilla.org/mozilla-central/rev/5469c3c3506d
Assignee: nobody → tomer.moz.bugs
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Flags: needinfo?(tomer.moz.bugs)
See Also: → 1269186
You need to log in before you can comment on or make changes to this bug.