Sharing an email copies mailto:

RESOLVED FIXED in Firefox 17

Status

()

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: mcomella)

Tracking

(Blocks 1 bug)

Trunk
Firefox 17
ARM
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

7 years ago
Long-tap and hold on any email link, such at the attached URL and opt to share it in Twitter or Facebook. 

Expected: lol@cats.org
Actual: mailto:lol@cats.org
Reporter

Comment 2

7 years ago
That's true. Do we have copy email address?
Bug 684380 is somewhat related. So is bug 718437.
"Copy Email Address" is bug 774766, which I made copy only the address and not "mailto:". Should sharing an email address also remove "mailto:"?
Posted patch Patch (obsolete) — Splinter Review
Made a patch for this. If we don't want it, we can toss it.

Note that this builds on the patch from bug 776064 so you should probably review that first.
Attachment #644544 - Flags: review?(mark.finkle)
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment on attachment 644544 [details] [diff] [review]
Patch


>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js
>+    emailLinkContext: {

>+        if (uri) {
>+          return uri.schemeIs("mailto");
>+        }

nit: {} not needed for a one-line block

We can decide on the strings in the other bug
Attachment #644544 - Flags: review?(mark.finkle) → review+
Posted patch Patch v2Splinter Review
(In reply to Mark Finkle (:mfinkle) from comment #6)
> Comment on attachment 644544 [details] [diff] [review]
> Patch
> nit: {} not needed for a one-line block

Fixed nit. Moved r+.
Attachment #644544 - Attachment is obsolete: true
Attachment #645082 - Flags: review+
Code is built upon the patch from bug 776064 and thus that patch needs to be pushed first.
Depends on: 776064
Before sure to push bug 776064 first.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71bbf99f060f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.