744662 - Sharing an email copies mailto:

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Long-tap and hold on any email link, such at the attached URL and opt to share it in Twitter or Facebook. 

Expected: [e-mail]
Actual: mailto:[e-mail]

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

but "mailto:[e-mail]" _is_ the link

Comment 2

[Aaron Train [:aaronmt]]

That's true. Do we have copy email address?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 684380 is somewhat related. So is bug 718437.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

"Copy Email Address" is bug 774766, which I made copy only the address and not "mailto:". Should sharing an email address also remove "mailto:"?

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

Made a patch for this. If we don't want it, we can toss it.

Note that this builds on the patch from bug 776064 so you should probably review that first.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 644544 [details] [diff] [review]
Patch


>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js
>+    emailLinkContext: {

>+        if (uri) {
>+          return uri.schemeIs("mailto");
>+        }

nit: {} not needed for a one-line block

We can decide on the strings in the other bug

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch v2

(In reply to Mark Finkle (:mfinkle) from comment #6)
> Comment on attachment 644544 [details] [diff] [review]
> Patch
> nit: {} not needed for a one-line block

Fixed nit. Moved r+.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Code is built upon the patch from bug 776064 and thus that patch needs to be pushed first.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Before sure to push bug 776064 first.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=2225f75a2f66

https://hg.mozilla.org/integration/mozilla-inbound/rev/71bbf99f060f

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/71bbf99f060f