745259 - Alsa almost always crashes or i-loops when getting hints on Linux

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Disables checking hints for sound devices in Alsa

Tested on both Ubuntu 11 and Fedora 15
Attached is a temporary patch to disable the hints call

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

This is very likely an Alsa bug with using -1 (get all cards) with the Alsa hint call, issue 95797 in Chromium:
http://code.google.com/p/chromium/issues/detail?id=95797

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Submitted issue 450:
http://code.google.com/p/webrtc/issues/detail?id=450

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Workaround for ALSA 2.0.0 (others?) bug in snd_device_name_hint(-1,...)

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 616704 [details] [diff] [review]
Workaround for ALSA 2.0.0 (others?) bug in snd_device_name_hint(-1,...)

I'll accept review/feedback from anyone :-)

If this looks good I plan to submit it to the webrtc.org issue

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: (alder/default version) Workaround for ALSA 2.0.0 (others?) bug in snd_device_name_hint(-1,...)

Comment 6

[Ethan Hugg [:ehugg]]

Comment on attachment 616704 [details] [diff] [review]
Workaround for ALSA 2.0.0 (others?) bug in snd_device_name_hint(-1,...)

Tested with paris_demo on Ubuntu 11.10.

Comment 7

[Ethan Hugg [:ehugg]]

Comment on attachment 616751 [details] [diff] [review]
(alder/default version) Workaround for ALSA 2.0.0 (others?) bug in snd_device_name_hint(-1,...)

Tested with paris_demo on Ubuntu 11.10.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Checked into paris_demo and default
https://hg.mozilla.org/projects/alder/rev/f290ab4673a1
https://hg.mozilla.org/projects/alder/rev/e1b19fc79795

Leaving open until fixed upstream and we can pull these patches