745524 - Minor code cleanup in PopupNotifications.jsm

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Form PopupNotifications.jsm.
*Define some properties which are substituted but not clearly specify.
*Add curly bracket to statement.
*Fill "," or ";".

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: proposed patch

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 615122 [details] [diff] [review]
proposed patch

I'd rather not do all the brace conversion (|if (x) y| --> |if(x) { y }|.

The other parts should be fine, though I'd like to look again without the extra diffs from the bracing.

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch (part1)

The patch without bracing.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch (part2)

The patch with bracing only.
I think, add bracing will be decrease bugs and developer's cobweb on debug.
And also, changing parts will separate purely from add bracing in the future.

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch (part2)

The patch with bracing only.
I think, add bracing will be decrease bugs and developer's cobweb on debug.
And also, changing parts will separate purely from add bracing in the future.

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 615194 [details] [diff] [review]
patch (part1)

r+, again I didn't test so assuming it works. ;)

Comment 7

[Justin Dolske [:Dolske]]

Comment on attachment 615197 [details] [diff] [review]
patch (part2)

Review of attachment 615197 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #5)
> The patch with bracing only.
> I think, add bracing will be decrease bugs and developer's cobweb on debug.
> And also, changing parts will separate purely from add bracing in the future.

Style here varies across the codebase; some places do it one way, others do it the other way. I don't think there's much value in changing existing code (and, similarly, I would accept new code using either style). About the only constant is that when using if+else, when either block is braced the other block should be too.

So r- on this part2.

(For the record: Landing just part 1 and closing this bug is ok.)

Comment 8

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Justin Dolske [:Dolske] from comment #7)
> Comment on attachment 615197 [details] [diff] [review]
> patch (part2)
> 
> Review of attachment 615197 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #5)
> > The patch with bracing only.
> > I think, add bracing will be decrease bugs and developer's cobweb on debug.
> > And also, changing parts will separate purely from add bracing in the future.
> 
> Style here varies across the codebase; some places do it one way, others do
> it the other way. I don't think there's much value in changing existing code
> (and, similarly, I would accept new code using either style). About the only
> constant is that when using if+else, when either block is braced the other
> block should be too.
> 
> So r- on this part2.
> 
> (For the record: Landing just part 1 and closing this bug is ok.)

I get your account. Thank you for the review.
I'll make the patch for check-in.

Comment 9

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch for check-in

This patch for check-in.

Comment 10

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b69c5c0bb727

Comment 11

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/b69c5c0bb727