Closed Bug 745525 Opened 9 years ago Closed 9 years ago

Use handleEvent in PopupNotifications

Categories

(Firefox :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: tetsuharu, Assigned: tetsuharu)

References

Details

(Whiteboard: [doorhanger])

Attachments

(1 file, 1 obsolete file)

Use handleEvent in PopupNotifications.
Depends on: 745524
Whiteboard: [doorhanger]
Attached patch proposed patch (obsolete) — Splinter Review
Attachment #615123 - Flags: review?(dolske)
This seems roughly ok from a quick skim, but what's the reason for making this change? Just code cleanup?
(In reply to Justin Dolske [:Dolske] from comment #2)
> This seems roughly ok from a quick skim, but what's the reason for making
> this change? Just code cleanup?

Yes. This change purposes to clean up.
Using handleEvent can decrease the part of using Function.bind() or making functions for listener only.
Comment on attachment 615123 [details] [diff] [review]
proposed patch

r+ assuming this passes tests -- I didn't test it. :)
Attachment #615123 - Flags: review?(dolske) → review+
Attached patch proposed patchSplinter Review
Rebase on the latest mozilla-central.
I can't Mochitest on all-platform because I don't have the permission to access to try-server.
But I have tried this patch, this patch worked good.
Attachment #615123 - Attachment is obsolete: true
Attachment #615202 - Flags: review?(dolske)
Comment on attachment 615202 [details] [diff] [review]
proposed patch

Would you like tryserver access? Looks like you've been busy with lots of Mozilla stuff, so I'd be happy to vouch for you. See http://www.mozilla.org/hacking/commit-access-policy/ and http://www.mozilla.org/hacking/committer/ -- CC me if you file a bug for access so I can vouch.
Attachment #615202 - Flags: review?(dolske) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/9a2f5f601616
Assignee: nobody → saneyuki.s.snyk
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/9a2f5f601616
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.