745567 - Android XUL builds about page fails to display build date and Telemetry warning

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

How many times do I have to fix this?

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7702bca6b64d&tochange=e636439e342f

Would seem to be Bug 702284 since it is the one that mucked with this code.

Comment 1

[Bill Gianopoulos [:WG9s]]

bug 702284 was confirmed as the regressor via backout.

Comment 2

[Aaron Train [:aaronmt]]

Feel free to assign yourself.

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Feel free to assign yourself.

I fail to understand how this fixes the issue that I fixed this once before and now someone else came along and broke it!

Comment 4

[Théo Chevalier]

(In reply to Bill Gianopoulos [:WG9s] from comment #3)
> I fail to understand how this fixes the issue that I fixed this once before
> and now someone else came along and broke it!

Really sorry about that. :( I can't see where my patch broke it. I don't understand, the try-builds were working...

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to Théo Chevalier [:tchevalier] from comment #4)
> (In reply to Bill Gianopoulos [:WG9s] from comment #3)
> > I fail to understand how this fixes the issue that I fixed this once before
> > and now someone else came along and broke it!
> 
> Really sorry about that. :( I can't see where my patch broke it. I don't
> understand, the try-builds were working...

My comment was not meant about you.  I realize sometimes when you try to fix one thing something unexpected breaks.  Was more pionted towards the really stupid comment from aaronmt.

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Bill Gianopoulos [:WG9s] from comment #5)
[...]

Please see #1 and #3.

https://bugzilla.mozilla.org/page.cgi?id=etiquette.html

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to Aaron Train [:aaronmt] from comment #6)
> (In reply to Bill Gianopoulos [:WG9s] from comment #5)
> [...]
> 
> Please see #1 and #3.
> 
> https://bugzilla.mozilla.org/page.cgi?id=etiquette.html

??????????????????????????????????????????????????????????????????????????

Comment 8

[Bill Gianopoulos [:WG9s]]

arronme: Some of us are trying to solve a  bug here.  Please leave whatever your other issues are elsewhere.

Comment 9

[Bill Gianopoulos [:WG9s]]

s/arronme/arronmt/

Comment 10

[Bill Gianopoulos [:WG9s]]

Attachment: Integrate bug 702284 and bug 728737 patches

OK. It seems what happened here was that bug 702284 was being worked before my patch for bug 728737 landed.  This integrates both patches so that they don't stomp on each other resulting in neither message being displayed.

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 615932 [details] [diff] [review]
Integrate bug 702284 and bug 728737 patches

This change looks good, though I still don't understand what went wrong to cause this regression.

Comment 12

[Bill Gianopoulos [:WG9s]]

My build from here http://www.wg9s.com/mozilla/firefox/fennec-14.0a1.en-US.android-arm-xul.apk shows both the telemetry warning and the build date, where the current nightly displays neither.

Comment 13

[Bill Gianopoulos [:WG9s]]

Attachment: Patch with check-in comment

Comment 14

[Bill Gianopoulos [:WG9s]]

Comment on attachment 615932 [details] [diff] [review]
Integrate bug 702284 and bug 728737 patches

I am asking for approval mozilla-central on this although it would seem to be a trivial issue impacting mobile.  However it is XUL only so should have no impact on Fennec native 1.0.

Also, I believe it is the cause of bug 746527, which is quite a serious regression for Android XUL.

Comment 15

[Bill Gianopoulos [:WG9s]]

(In reply to Bill Gianopoulos [:WG9s] from comment #14)
> Comment on attachment 615932 [details] [diff] [review]
> Also, I believe it is the cause of bug 746527, which is quite a serious
> regression for Android XUL.

I meant to say, I believe this will FIX bug 746527.

Comment 16

[Matt Brubeck (:mbrubeck)]

Comment on attachment 615932 [details] [diff] [review]
Integrate bug 702284 and bug 728737 patches

https://hg.mozilla.org/integration/mozilla-inbound/rev/12a2ee1f0088

Comment 17

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/12a2ee1f0088

Comment 18

[Bill Gianopoulos [:WG9s]]

Verified fixed with 20120420 nightly.