Closed Bug 745567 Opened 12 years ago Closed 12 years ago

Android XUL builds about page fails to display build date and Telemetry warning

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 14

People

(Reporter: wgianopoulos, Assigned: wgianopoulos)

References

Details

(Keywords: regression)

Attachments

(2 files)

How many times do I have to fix this?

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7702bca6b64d&tochange=e636439e342f

Would seem to be Bug 702284 since it is the one that mucked with this code.
OS: Linux → Android
Hardware: x86 → ARM
bug 702284 was confirmed as the regressor via backout.
Severity: normal → major
Feel free to assign yourself.
(In reply to Aaron Train [:aaronmt] from comment #2)
> Feel free to assign yourself.

I fail to understand how this fixes the issue that I fixed this once before and now someone else came along and broke it!
(In reply to Bill Gianopoulos [:WG9s] from comment #3)
> I fail to understand how this fixes the issue that I fixed this once before
> and now someone else came along and broke it!

Really sorry about that. :( I can't see where my patch broke it. I don't understand, the try-builds were working...
(In reply to Théo Chevalier [:tchevalier] from comment #4)
> (In reply to Bill Gianopoulos [:WG9s] from comment #3)
> > I fail to understand how this fixes the issue that I fixed this once before
> > and now someone else came along and broke it!
> 
> Really sorry about that. :( I can't see where my patch broke it. I don't
> understand, the try-builds were working...

My comment was not meant about you.  I realize sometimes when you try to fix one thing something unexpected breaks.  Was more pionted towards the really stupid comment from aaronmt.
(In reply to Bill Gianopoulos [:WG9s] from comment #5)
[...]

Please see #1 and #3.

https://bugzilla.mozilla.org/page.cgi?id=etiquette.html
(In reply to Aaron Train [:aaronmt] from comment #6)
> (In reply to Bill Gianopoulos [:WG9s] from comment #5)
> [...]
> 
> Please see #1 and #3.
> 
> https://bugzilla.mozilla.org/page.cgi?id=etiquette.html

??????????????????????????????????????????????????????????????????????????
arronme: Some of us are trying to solve a  bug here.  Please leave whatever your other issues are elsewhere.
s/arronme/arronmt/
OK. It seems what happened here was that bug 702284 was being worked before my patch for bug 728737 landed.  This integrates both patches so that they don't stomp on each other resulting in neither message being displayed.
Assignee: nobody → bill
Status: NEW → ASSIGNED
Attachment #615932 - Flags: review?(mbrubeck)
Comment on attachment 615932 [details] [diff] [review]
Integrate bug 702284 and bug 728737 patches

This change looks good, though I still don't understand what went wrong to cause this regression.
Attachment #615932 - Flags: review?(mbrubeck) → review+
My build from here http://www.wg9s.com/mozilla/firefox/fennec-14.0a1.en-US.android-arm-xul.apk shows both the telemetry warning and the build date, where the current nightly displays neither.
Summary: Yet again, Android XUL builds about page fails to show build date → Android XUL builds about page fail to show build date and Telemetry warning
Summary: Android XUL builds about page fail to show build date and Telemetry warning → Android XUL builds about page fails to display build date and Telemetry warning
Keywords: checkin-needed
Attachment #615957 - Attachment description: PAtch with check-in comment → Patch with check-in comment
Whiteboard: please check-in attachment 615957
Blocks: 746527
Comment on attachment 615932 [details] [diff] [review]
Integrate bug 702284 and bug 728737 patches

I am asking for approval mozilla-central on this although it would seem to be a trivial issue impacting mobile.  However it is XUL only so should have no impact on Fennec native 1.0.

Also, I believe it is the cause of bug 746527, which is quite a serious regression for Android XUL.
Attachment #615932 - Flags: approval-mozilla-central?
(In reply to Bill Gianopoulos [:WG9s] from comment #14)
> Comment on attachment 615932 [details] [diff] [review]
> Also, I believe it is the cause of bug 746527, which is quite a serious
> regression for Android XUL.

I meant to say, I believe this will FIX bug 746527.
Keywords: checkin-needed
Whiteboard: please check-in attachment 615957
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/12a2ee1f0088
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified fixed with 20120420 nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: