Closed
Bug 746037
Opened 13 years ago
Closed 13 years ago
Message tab has 1px margin on the left
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: squib, Assigned: Paenglab)
Details
Attachments
(1 file)
|
975 bytes,
patch
|
squib
:
review+
|
Details | Diff | Splinter Review |
It should be fairly easy to spot this issue if you know where to look for: try opening a message in a tab and look at the border at the bottom of the message headers. It doesn't go all the way to the left edge.
I think this is my fault, specifically in this change: http://hg.mozilla.org/comm-central/diff/96ec61738c96/mail/themes/qute/mail/mailWindow1-aero.css
Paenglab, maybe you know what's going on with this, or have some idea of how to fix it?
|
Assignee | |
Comment 1•13 years ago
|
||
This margin isn't needed, so remove it. And give the splitter 1px less negative margin to not overlap the list.
Squib, is it okay to you give this review?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #616240 -
Flags: review?(squibblyflabbetydoo)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 616240 [details] [diff] [review]
remove the margin
Review of attachment 616240 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me! (Though I tested it by monkey-patching an existing install on Windows...)
Attachment #616240 -
Flags: review?(squibblyflabbetydoo) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•