Last Comment Bug 746037 - Message tab has 1px margin on the left
: Message tab has 1px margin on the left
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: 12 Branch
: All Windows 7
: -- trivial (vote)
: Thunderbird 14.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-16 19:03 PDT by Jim Porter (:squib)
Modified: 2012-04-19 16:02 PDT (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
remove the margin (975 bytes, patch)
2012-04-18 12:13 PDT, Richard Marti (:Paenglab)
squibblyflabbetydoo: review+
Details | Diff | Splinter Review

Description Jim Porter (:squib) 2012-04-16 19:03:38 PDT
It should be fairly easy to spot this issue if you know where to look for: try opening a message in a tab and look at the border at the bottom of the message headers. It doesn't go all the way to the left edge.

I think this is my fault, specifically in this change: http://hg.mozilla.org/comm-central/diff/96ec61738c96/mail/themes/qute/mail/mailWindow1-aero.css

Paenglab, maybe you know what's going on with this, or have some idea of how to fix it?
Comment 1 Richard Marti (:Paenglab) 2012-04-18 12:13:43 PDT
Created attachment 616240 [details] [diff] [review]
remove the margin

This margin isn't needed, so remove it. And give the splitter 1px less negative margin to not overlap the list.

Squib, is it okay to you give this review?
Comment 2 Jim Porter (:squib) 2012-04-18 21:46:35 PDT
Comment on attachment 616240 [details] [diff] [review]
remove the margin

Review of attachment 616240 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! (Though I tested it by monkey-patching an existing install on Windows...)
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-04-19 16:02:38 PDT
http://hg.mozilla.org/comm-central/rev/acc7a04221a0

Note You need to log in before you can comment on or make changes to this bug.