746107 - add outputTextAttrs helper function to JSDialog of AccessibleTree view

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

anonymous function, not sure how to say about it in UI without any good rework.

Comment 1

[[e-mail]]

Why don't the text attributes appear in the accessible properties viewer?

Alternatively, is there a value in sharing these functions with the evaluator and the accessible event handlers?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to [e-mail] from comment #1)
> Why don't the text attributes appear in the accessible properties viewer?

text attributes takes an offset the text attributes are calculated at, for example,
<p><b>bold</b>normal</p>
so text attributes on p accessible at 0 offset are "font-weitht: 700", at 4 offset is empty set.

> Alternatively, is there a value in sharing these functions with the
> evaluator and the accessible event handlers?

absolutely, all helper methods should be shared between them (iirc I didn't file bug on that yet).

Comment 3

[[e-mail]]

(In reply to alexander surkov from comment #2)
> (In reply to comment #1)
> > Why don't the text attributes appear in the accessible properties viewer?
> text attributes takes an offset the text attributes are calculated at, for
> example,
> <p><b>bold</b>normal</p>
> so text attributes on p accessible at 0 offset are "font-weitht: 700", at 4
> offset is empty set.
Sorry, the question I meant to ask was "Why don't you display text attributes in the relevant accessible viewer?"

Comment 4

[alexander :surkov (:asurkov)]

(In reply to [e-mail] from comment #3)
> Sorry, the question I meant to ask was "Why don't you display text
> attributes in the relevant accessible viewer?"

are you asking about nice UI for text attributes instead of having an utility function to print them out in console? If yes, then I think it makes sense to keep them both. We have bug 738232 for UI.

Comment 5

[alexander :surkov (:asurkov)]

(cc'ing Neil)

Comment 6

[[e-mail]]

(sorry, I'm so far behind on my review queue that Bugzilla pinged me again...)

Comment 7

[alexander :surkov (:asurkov)]

please take your time. I just started to use DOMi for tricky a11y examples again and wanted to flush my DOMi queue.

Comment 8

[[e-mail]]

Comment on attachment 615673 [details] [diff] [review]
patch

Well, I eventually found something with a text attribute on the SeaMonkey start page :-)

>+      var enumerate = attrs.enumerate();
Nit: variable is traditionally named enumerator.

>+      if (str)
>+        output(str);
str is never null here, no point wrapping it in an if. Or you could just output everything individually.

Comment 9

[alexander :surkov (:asurkov)]

landed with Neil's comments addressed - http://hg.mozilla.org/dom-inspector/rev/fe054428d6aa