Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Followup patch to add missing elements from bug patches: 734121, 73638, 688061 & 738404

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

unspecified
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bugs: 734121, 735638, 688061, 738404

Not all logic from these patches have landed.  Some may have been merged away, checkifEmpty macro was re-added.  At this point it will be easiest to start with a clean checkout of mozilla-central and re-add missing elements in a new patch.
(Assignee)

Updated

5 years ago
Depends on: 734121, 735638, 688061, 738404
(Assignee)

Comment 1

5 years ago
Created attachment 616099 [details] [diff] [review]
re-add approved patch edits that were merged away

Clean sandbox checkout and re-added missing elements.
  o user functions: map, checkIfEmpty, errorIfEmpty, warnIfEmpty
  o manual unit test for checkIfEmpty, warnIfEmpty

New addition (minor):
  o wrap definition of *ifEmpty functions with a target conditional.  If target is a permutation of 'make clean', function(s) should not be defined or make clean in a semi-clean sandbox will fail when data files on disk have not yet been created.
Assignee: nobody → joey
Attachment #616099 - Flags: review?(coop)
(Assignee)

Comment 2

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=a7a9ef98be84

Updated

5 years ago
Attachment #616099 - Flags: review?(coop) → review+

Comment 3

5 years ago
Comment on attachment 616099 [details] [diff] [review]
re-add approved patch edits that were merged away

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d088e87879

Comment 4

5 years ago
Try run for a590fbe22a2f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a590fbe22a2f
Results (out of 15 total builds):
    exception: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/coop@mozilla.com-a590fbe22a2f

Comment 5

5 years ago
(In reply to Mozilla RelEng Bot from comment #4)
> Try run for a590fbe22a2f is complete.

Disregard this. I cancelled it shortly after I realized it wasn't going to provide any new data.

The mozilla-inbound landing above seems to have stuck. Just waiting for the merge to m-c to resolved this bug.

Comment 6

5 years ago
(In reply to Chris Cooper [:coop] from comment #5)
> The mozilla-inbound landing above seems to have stuck. Just waiting for the
> merge to m-c to resolved this bug.

...and Ed did that this morning.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f3d088e87879
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.