746151 - Followup patch to add missing elements from bug patches: 734121, 73638, 688061 & 738404

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

bugs: 734121, 735638, 688061, 738404

Not all logic from these patches have landed.  Some may have been merged away, checkifEmpty macro was re-added.  At this point it will be easiest to start with a clean checkout of mozilla-central and re-add missing elements in a new patch.

Comment 1

[Joey Armstrong [:joey]]

Attachment: re-add approved patch edits that were merged away

Clean sandbox checkout and re-added missing elements.
  o user functions: map, checkIfEmpty, errorIfEmpty, warnIfEmpty
  o manual unit test for checkIfEmpty, warnIfEmpty

New addition (minor):
  o wrap definition of *ifEmpty functions with a target conditional.  If target is a permutation of 'make clean', function(s) should not be defined or make clean in a semi-clean sandbox will fail when data files on disk have not yet been created.

Comment 2

[Joey Armstrong [:joey]]

https://tbpl.mozilla.org/?tree=Try&rev=a7a9ef98be84

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 616099 [details] [diff] [review]
re-add approved patch edits that were merged away

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d088e87879

Comment 4

[Mozilla RelEng Bot]

Try run for a590fbe22a2f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a590fbe22a2f
Results (out of 15 total builds):
    exception: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a590fbe22a2f

Comment 5

[Chris Cooper [:coop] (he/him)]

(In reply to Mozilla RelEng Bot from comment #4)
> Try run for a590fbe22a2f is complete.

Disregard this. I cancelled it shortly after I realized it wasn't going to provide any new data.

The mozilla-inbound landing above seems to have stuck. Just waiting for the merge to m-c to resolved this bug.

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to Chris Cooper [:coop] from comment #5)
> The mozilla-inbound landing above seems to have stuck. Just waiting for the
> merge to m-c to resolved this bug.

...and Ed did that this morning.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f3d088e87879