Closed Bug 746151 Opened 9 years ago Closed 9 years ago

Followup patch to add missing elements from bug patches: 734121, 73638, 688061 & 738404

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: joey, Assigned: joey)

References

Details

Attachments

(1 file)

bugs: 734121, 735638, 688061, 738404

Not all logic from these patches have landed.  Some may have been merged away, checkifEmpty macro was re-added.  At this point it will be easiest to start with a clean checkout of mozilla-central and re-add missing elements in a new patch.
Depends on: 734121, 735638, 688061, 738404
Clean sandbox checkout and re-added missing elements.
  o user functions: map, checkIfEmpty, errorIfEmpty, warnIfEmpty
  o manual unit test for checkIfEmpty, warnIfEmpty

New addition (minor):
  o wrap definition of *ifEmpty functions with a target conditional.  If target is a permutation of 'make clean', function(s) should not be defined or make clean in a semi-clean sandbox will fail when data files on disk have not yet been created.
Assignee: nobody → joey
Attachment #616099 - Flags: review?(coop)
Attachment #616099 - Flags: review?(coop) → review+
Try run for a590fbe22a2f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a590fbe22a2f
Results (out of 15 total builds):
    exception: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/coop@mozilla.com-a590fbe22a2f
(In reply to Mozilla RelEng Bot from comment #4)
> Try run for a590fbe22a2f is complete.

Disregard this. I cancelled it shortly after I realized it wasn't going to provide any new data.

The mozilla-inbound landing above seems to have stuck. Just waiting for the merge to m-c to resolved this bug.
(In reply to Chris Cooper [:coop] from comment #5)
> The mozilla-inbound landing above seems to have stuck. Just waiting for the
> merge to m-c to resolved this bug.

...and Ed did that this morning.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.