734121 - makefile: add utility functions for identifying argument calling context for user functions

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

Define utility functions for make use that can identify the argument calling context for user defined functions.  Scalar and list at a miniumum.

istype()
isval()
isvar()

Use these to define a another function getvals() able to expand calling arguments so functions can be called as either:
   $(call func,var_of_values)
   $(call func,val1 val2 val3)

Also add a check unit test to validate behavior.

Logic can eventually be used by bug 680246 -- mkdir_deps -- to simplify usage.

Comment 1

[Joey Armstrong [:joey]]

Attachment: helper macros for writing make user functions

makeutils.mk - a makefile of helper macros for writing user functions { to be used by 680246 }.  Unit test included to lock down functionality.

allmakefiles.sh - a few /test(s)?/ entries were outside the ENABLE_TESTS block so moved them inside.

Comment 2

[Joey Armstrong [:joey]]

code review ping

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 605375 [details] [diff] [review]
helper macros for writing make user functions

Review of attachment 605375 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/test/manual.sh
@@ +4,5 @@
> +## obj unless configure is run so force it.
> +
> +# cd $obj/config/makefiles/test
> +make -C ../../../.. -f client.mk configure
> +make check

Er, what is this for?

Comment 4

[Joey Armstrong [:joey]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> Comment on attachment 605375 [details] [diff] [review]
> helper macros for writing make user functions
> 
> Review of attachment 605375 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: config/makefiles/test/manual.sh
> @@ +4,5 @@
> > +## obj unless configure is run so force it.
> > +
> > +# cd $obj/config/makefiles/test
> > +make -C ../../../.. -f client.mk configure
> > +make check
> 
> Er, what is this for?

Just a helper script to force Makefile to regenerate while testing the check target.  Deps for Makefile: Makefile.in are not always forcing the target to regenerate, at least while pwd=${obj}/.... and a named target is in use.

Comment 5

[Joey Armstrong [:joey]]

Attachment: helper macros for writing make user functions

Same patch as last time but with the helper script removed.  Can manually copy in the script to force makefile regeneration when testing is required.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 607555 [details] [diff] [review]
helper macros for writing make user functions

Review of attachment 607555 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, as long as that forced reconfigure isn't actually happening, this looks fine.

Comment 7

[Joey Armstrong [:joey]]

these makefile edits should simmer in b-s for a while.

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 607555 [details] [diff] [review]
helper macros for writing make user functions

https://hg.mozilla.org/projects/build-system/rev/6236ee493160

A little bit of skew in allmakefiles.sh, but I cleaned that up.

Comment 9

[Joey Armstrong [:joey]]

Patch landed on mozilla-central yesterday by Coop & Philor:
https://hg.mozilla.org/mozilla-central/rev/c598b7b202e7