remove -l flag from nsinstall

RESOLVED FIXED in mozilla18

Status

RESOLVED FIXED
7 years ago
8 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla18

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

As bug 745209 showed, nsinstall's -l flag is busted and unused (-L implies it; -R is more convenient to use).  We should just remove it so it doesn't cause problems elsewhere.
Created attachment 661923 [details] [diff] [review]
patch
Attachment #661923 - Flags: review?(mh+mozilla)
Comment on attachment 661923 [details] [diff] [review]
patch

Review of attachment 661923 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/nsinstall.c
@@ +289,5 @@
>  	    linkprefix = optarg;
>  	    lplen = strlen(linkprefix);
>  	    dolink = 1;
>  	    break;
>       case 'R':

While you're here, can you indent this properly?
Attachment #661923 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #2)
> @@ +289,5 @@
> >  	    linkprefix = optarg;
> >  	    lplen = strlen(linkprefix);
> >  	    dolink = 1;
> >  	    break;
> >       case 'R':
> 
> While you're here, can you indent this properly?

"Properly" is such an ambiguous description when applied to nsinstall.c's formatting. ;)

https://hg.mozilla.org/integration/mozilla-inbound/rev/be916ac9a1b4
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED

Comment 4

6 years ago
Broke the build across the board, so I backed it out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7fce994eaa

Comment 5

6 years ago
(In reply to Mike Hommey [:glandium] from comment #2)
> While you're here, can you indent this properly?

But... but... this file adds character to the tree with its mixed usage of spaces and tabs ON THE SAME LINE! :)
https://hg.mozilla.org/mozilla-central/rev/ed057f2acc29
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.