Closed
Bug 746223
Opened 13 years ago
Closed 13 years ago
remove -l flag from nsinstall
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
2.33 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
As bug 745209 showed, nsinstall's -l flag is busted and unused (-L implies it; -R is more convenient to use). We should just remove it so it doesn't cause problems elsewhere.
![]() |
Assignee | |
Comment 1•13 years ago
|
||
Attachment #661923 -
Flags: review?(mh+mozilla)
Comment 2•13 years ago
|
||
Comment on attachment 661923 [details] [diff] [review]
patch
Review of attachment 661923 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/nsinstall.c
@@ +289,5 @@
> linkprefix = optarg;
> lplen = strlen(linkprefix);
> dolink = 1;
> break;
> case 'R':
While you're here, can you indent this properly?
Attachment #661923 -
Flags: review?(mh+mozilla) → review+
![]() |
Assignee | |
Comment 3•13 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2)
> @@ +289,5 @@
> > linkprefix = optarg;
> > lplen = strlen(linkprefix);
> > dolink = 1;
> > break;
> > case 'R':
>
> While you're here, can you indent this properly?
"Properly" is such an ambiguous description when applied to nsinstall.c's formatting. ;)
https://hg.mozilla.org/integration/mozilla-inbound/rev/be916ac9a1b4
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Comment 4•13 years ago
|
||
Broke the build across the board, so I backed it out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7fce994eaa
Comment 5•13 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2)
> While you're here, can you indent this properly?
But... but... this file adds character to the tree with its mixed usage of spaces and tabs ON THE SAME LINE! :)
![]() |
Assignee | |
Comment 6•13 years ago
|
||
Relanded with changes to js/src/config as well:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed057f2acc29
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•