746283 - sut_tools should support logging from clientproxy multiprocess.

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: [tools] v1

sut_lib should support logging rather than print in more instances. As well as actually log to the clientproxy log when we are called from there.

To do this s/print/log.*/ and add a sut_lib init for multiprocessing logging.

Comment 1

[Mike Taylor [:bear]]

Comment on attachment 615827 [details] [diff] [review]
[tools] v1

I don't think you need to use a common routine to get the log instance - that is what get_logger() returns.

You should be able to replace your multiprocessingLoggingInit() routine with:

from multiprocessing import get_logger

log = get_logger()

and ensure that log has module scope

Comment 2

[Justin Wood (:Callek)]

Attachment: [tools] v2

After IRC discussion this feels less dirty.

Comment 3

[Mike Taylor [:bear]]

Comment on attachment 615866 [details] [diff] [review]
[tools] v2

nit: remove the |if debug:| check, log.debug() does that

but doing this will mean setting the log debug level based on the option

Comment 4

[Justin Wood (:Callek)]

(In reply to Mike Taylor [:bear] from comment #3)
> Comment on attachment 615866 [details] [diff] [review]
> [tools] v2
> 
> nit: remove the |if debug:| check, log.debug() does that

Per IRC ok from bear, I'm planning to ignore this nit since changing the calling location is a bit scope creeping of making this library log properly.

Comment 5

[Justin Wood (:Callek)]

http://hg.mozilla.org/build/tools/rev/a874d4fb96f9

Comment 6

[Justin Wood (:Callek)]

This deployed