749863 - Make sut_tools actually output to stdout now that it is using log module

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: [tools] v1

Many buildbot scripts use sut_tools as well, and apparantly |log = logging.getLogger()| is not enough to give a StreamHandler as the output.

This will do it just fine for all of sut_tools. Alternative is to set |log = logging| and use logging.basicConfig() to set the level here. But I like this better (less magic involved)

Comment 1

[Justin Wood (:Callek)]

Attachment: [tools] v2

This implements the more restrictive ps echoing than we had before. Rest of patch is the same

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 620433 [details] [diff] [review]
[tools] v2

>@@ -508,7 +519,14 @@ def stopStalled(tegra):
>+    log.debug("checkStalled: matching Processes follow...")

Corrected to read "stopStalled" here

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 620433 [details] [diff] [review]
[tools] v2

http://hg.mozilla.org/build/tools/rev/addb0b598d3f

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 620433 [details] [diff] [review]
[tools] v2

Had to back this out, it was causing clientproxy to fail to startup (somehow staging didn't catch that initially).

And needed a context fix for a backout conflict:
http://hg.mozilla.org/build/tools/rev/272efac7ec20 (backout)
http://hg.mozilla.org/build/tools/rev/eca68fbcc7c0 (merge)
http://hg.mozilla.org/build/tools/rev/c0122cac3804 (context-fix)

Comment 5

[Ed Morley [:emorley]]

(Much of the attached patch is now covered by bug 781341 and bug 794017).

Comment 6

[Justin Wood (:Callek)]

(In reply to Ed Morley [:edmorley UTC+0] from comment #5)
> (Much of the attached patch is now covered by bug 781341 and bug 794017).

Indeed, and fixed. [though we will have more logging cleanup to do]