Closed Bug 746369 Opened 8 years ago Closed 8 years ago

Cannot install apps that do not specify an icon in the app manifest - Clicking Install in App Doorhanger Does Nothing

Categories

(Firefox Graveyard :: Web Apps, defect, critical)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 14

People

(Reporter: jsmith, Assigned: Felipe)

References

Details

(Whiteboard: [marketplace-beta?])

Attachments

(1 file, 1 obsolete file)

Steps:

1. Install Nightly try-build (http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/myk@mozilla.com-7c9ffc51663f/)
2. Go to marketplace-dev.allizom.org
3. Install the In-App Payment tester (https://marketplace-dev.allizom.org/en-US/app/in-app-payment-tester/?src=search)
4. When the door-hanger appears, click install

Expected:

The application should install natively to the user's machine.

Actual:

Nothing happens. The door hanger is still persistent. Continuing to click install does nothing.

Error Console:

Error: TypeError: aIcons is not an object
Source File: resource:///modules/WebappsInstaller.jsm
Line: 366
This app's manifest does not specify icons: http://inapp-pay-test.farmdev.com/en-US/manifest.webapp

{"name": "In-app Payment Tester",
 "description": "Utility app to test in-app payments.",
 "version": "1.0",
 "developer": {"name": "---"},
 "launch_path": "/en-US/",
 "default_locale": "en",
 "installs_allowed_from": ["*"]
}

Should the marketplace accept apps without icons?
(In reply to Felipe Gomes (:felipe) from comment #1)
> This app's manifest does not specify icons:
> http://inapp-pay-test.farmdev.com/en-US/manifest.webapp
> 
> {"name": "In-app Payment Tester",
>  "description": "Utility app to test in-app payments.",
>  "version": "1.0",
>  "developer": {"name": "---"},
>  "launch_path": "/en-US/",
>  "default_locale": "en",
>  "installs_allowed_from": ["*"]
> }
> 
> Should the marketplace accept apps without icons?

I don't know (I'll check with Krupa), although the issue here could happen outside of the marketplace. Specifying icons is optional (https://developer.mozilla.org/en/Apps/Manifest). The case of when an icon isn't specified does need to be handled.
Summary: Cannot install In-App Payment Tester - Clicking Install in App Doorhanger Does Nothing → Cannot install apps that do not specify an icon in the app manifest - Clicking Install in App Doorhanger Does Nothing
OS: Mac OS X → All
Hardware: x86 → All
Severity: normal → major
Severity: major → critical
Whiteboard: [marketplace-beta?]
Need Krupa's and/or Marketplace team's take on this. 

If it's not necessary in the Mozilla Marketplace, I would not block on this release if the case is that 3rd party marketplaces cannot install without an icon since there are no 3rd party marketplaces at this time.
(In reply to Jennifer Arguello :ticachica from comment #3)
> Need Krupa's and/or Marketplace team's take on this. 

Krupa and Wil - Thoughts?

> If it's not necessary in the Mozilla Marketplace, I would not block on this
> release if the case is that 3rd party marketplaces cannot install without an
> icon since there are no 3rd party marketplaces at this time.

Remember that users can host their own applications freely, which we already know is being used. How does 3rd party app hosting get taken into account in this?
app icons are not required to submit an app in Marketplace.
What is then the icon that should be used if an app does not submit its own icon?
(In reply to Felipe Gomes (:felipe) from comment #6)
> What is then the icon that should be used if an app does not submit its own
> icon?

Can we use the rocket glyph as the default icon? We're seeing this bug quite a bit in trying to install Marketplace apps. Depending on ETA for a fix, we may need to reject apps without icons in their manifest for now.
Attached patch Patch (obsolete) — Splinter Review
If an app does not specify icons in the manifest this will use the rocket icon, thesame as displayed in the doorhanger
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attachment #616799 - Flags: review?(gavin.sharp)
Attached patch Patch v2Splinter Review
forgot to qref
Attachment #616799 - Attachment is obsolete: true
Attachment #616799 - Flags: review?(gavin.sharp)
Attachment #616800 - Flags: review?(gavin.sharp)
Attachment #616800 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/22bfdebf5cae
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Duplicate of this bug: 735789
Status: RESOLVED → VERIFIED
Flags: in-moztrap?(jsmith)
QA Contact: jsmith
Flags: in-moztrap?(jsmith)
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.