74651 - Password dialog should be modal to the mail window.

Status: VERIFIED WORKSFORME

(MailNews Core :: Backend, defect, P2)

Description

[Navin Gupta]

I investigated little bit and found it does not work on windows and linux. 
works on mac !!. I have seen this, both for IMAP and POP3

In nsMsgIncomingServer.cpp

we are doing this to get the password prompt

rv = dialog->PromptPassword(aPromptTitle, aPromptMessage, 
                    NS_ConvertASCIItoUCS2(serverUri).get(),                                         
nsIPrompt::SAVE_PASSWORD_PERMANENTLY,
                    getter_Copies(uniPassword), okayValue);


I don't know who the correct owner of the bug is, most likely should be outside 
mailnews.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 75045 has been marked as a duplicate of this bug. ***

Comment 2

[Navin Gupta]

nominating because it may disappear behind other windows

Comment 3

[Navin Gupta]

cc danm

Comment 4

[scottputterman]

Navin is this still happening to you or is there a specific way to make this
happen?  I'm using 2001042304 on Win 2000 and when I do GetMsg on a POP or IMAP
account it is modal

Comment 5

[scottputterman]

Navin or Esther, can you reproduce this?

Comment 6

[Sean Su]

dialog is modal for me as well under NT4.  However, I was able to get the 
password dialog to be modal to a window other than the mail/news window.  here 
are my steps:

1) run N6 (or mozilla).  make sure you are in the browser window when you 
attempt this test.
2) bring up the mail/news window, but the trick here is to be multitasking! As 
the mail/news window shows up, keep clicking on the browser window so that it 
will bring it to the foreground.  You should need to do this everytime the 
mail/news window attempts to be in the foreground (as its starting up).  You 
should only need to click the browser window twice.

Now notice that the password dialog is modal to the browser window. :)  We could 
probably rule this out as an "edge case".

Comment 7

[Navin Gupta]

looks like this problem is fixed now. Marking WFM, will reopen if I see it 
again. 

Comment 8

[esther]

I'm not sure what the bug was, what should this dialog be modal too?  App or
parent window?
Currently for windows and linux, if you have other windows opened such as
Address Book or Composer and minimized on the task bar you can bring them up
over the password dialog.  

1. Launch app
2. Open Address book and minimize
3. Open Composer and minimize
4. Open Mail, after password dialog comes up click on the address book or
composer in the task bar.  These will open and display over password dialog.  

Where a problem has happened is when I call up the New Msg window from either
the Address Book or Composer, Compose a msg and try to send.  At this time my
Sent folder is IMAP which requires me to be logged in, since I didn't complete
the login the compose window just sits there trying to send.  I didn't get an
error message and one of the 3 times I did this my app froze (windows).  

Comment 9

[Navin Gupta]

Reopening, seen on today's linux debug build.

Comment 10

[scottputterman]

moving to 0.9.2

Comment 11

[scottputterman]

moving to 0.9.3

Comment 12

[esther]

changing to nsbeta1-  can't be fixed at this time, new bug logged to remove the
menu item 86995

Comment 13

[scottputterman]

moving to 0.9.4

Comment 14

[Scott MacGregor]

triage --> .9.5

Comment 15

[Scott MacGregor]

i sure thought the password dialog already was modal. triaging anyway.

Comment 16

[Dan M]

The password dialog will be modal to something, or I'll eat my hat. Not the big 
one, mind. Sean Su's comment above (2001-04-30 14:56) is exactly the behaviour 
you'll see if you don't give the prompt window a parent. Given an explicit 
parent, it'll make itself dependent on that parent. Given no parent, it'll make 
itself dependent of the topmost app window. It's just the best we can do with 
what we know at the time, and it beats making HiddenWindow the parent. (Note that 
alerts are application modal on the Mac, which is therefore immune to this whole 
issue.)

Give the prompt window an explicit parent and this should clear right up.

Comment 17

[Scott MacGregor]

Yeah we do give it the mail 3-pane as the parent. We aren't using the hidden
window. For me the password dialog is modal to the 3-pane on win2k.

Comment 18

[Dan M]

Sean said the password dialog was normally modal to the mail window, but it would 
instead pick a different window if you forced that window to the front at just 
the right moment. If you're seeing it always modal to the mail window, well, no 
problem then.

Comment 19

[scottputterman]

esther, this is one of the bugs you were going to look into.

Comment 20

[esther]

I can not get the password dialog to be modal to any window but the 3-pane
window (which is correct).  I can hide the password dialog as described in my
comment on 4-30, but that isn't the problem as originally reported.  Navin,
since you reopened this can you check to see if you can still reproduce the
originally stated problem.  Thanks

Comment 21

[esther]

*** Bug 86720 has been marked as a duplicate of this bug. ***

Comment 22

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 109395 has been marked as a duplicate of this bug. ***

Comment 23

[Navin Gupta]

I have not see this for a while, tried to reproduce it but couldn't. 
will reopen if i see it again. 

Comment 24

[Yasuo Ohgaki]

Since my bug report marked as duplicate of this bug, I write comment for this bug. 

There is similar problem. This problem is more serious. 

1. Connect to NNTP server which is dead.
2. Open bookmark.
3. If NNTP connection timeout while bookmark is openned, it locks X inputs.

I had to zap X.

Build ID 2001112012 (Linux)

Comment 25

[Yasuo Ohgaki]

This issue is not about password dialog. If you think this should be separte
report, please let me know.

Following Mozilla Mail & Newsgroups dialogs block browser also (i.e. Can't
browser use menu, can't click links in displied page, etc)

 - Subscribe to newsgroup
 - View settings for this account
 - Create a new account
 - Offline settings

(Only "Search messages" does not block)

This problem is verified with today's (2001/11/27 JST) nightly build for linux.
(Build ID is 00000000. Something should be wrong.)

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

This is modal for me on windows 2000, build 2002-03-20.

verified wfm.