746590 - Fix in-tree mozconfigs to specify correct gcc location for Firefox Automation, and add missing mozconfig files

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

In testing moving over to the Firefox automation, we've discovered a couple of issues:

- The mozconfigs are specifying an old gcc location. We should sync up with the FF one to minimise the risk of issues.

- The Mac mozconfig has an old check to see if mozconfig.common exists, this is something that we had for 1.9.2 and we can just drop now.

- We're not specifying the REDIST_DIR in the mozconfig for the win32 nightly. Not a big issue as I think there's something that specifies it anyway, but it'll remind us to swap that file to VS 2010 when we get that far.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix v2

Updated patch to include what I think is necessary for debug builds on Mac to run properly.

Comment 2

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/comm-central/rev/9ab332464c5e

Comment 3

[Mark Banner (:standard8)]

Of course, I used endif rather than fi, so I've pushed a bustage fix for the staging builds for that:

http://hg.mozilla.org/comm-central/rev/6e7dfba5f1af

Comment 4

[John Hopkins (:jhopkins)]

Attachment: set CC,CXX inline

Undo portion of previous patch and update CC,CXX variables.  mozconfig.linux not available as mozilla-central hasn't been pulled yet, and there's no mozconfig.linux in comm-central, either.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 616844 [details] [diff] [review]
set CC,CXX inline

Review of attachment 616844 [details] [diff] [review]:
-----------------------------------------------------------------

John:

Hey, so, again, I'm not really privy to the details of our build stuff - but I think I understand what's going on here, and I approve.

Looks good.

-Mike

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 616844 [details] [diff] [review]
set CC,CXX inline

As an official build peer, r+=me

However john, IF YOU WANT you can have rs+=me to not land this patch and instead land an exact replica of mozilla/build/unix/mozconfig.linux in the corresponding cc directory.

SeaMonkey will be (soon) using gcc-4.5-0moz3 as well (right now we have 0moz2 installed) so we'd have a similar desire.

(which then even allows you to do away with the if test ... lines ;-) )

Comment 7

[John Hopkins (:jhopkins)]

callek: sounds reasonable - let's revisit that idea.

For now, I've landed the patch in http://hg.mozilla.org/comm-central/rev/63e28f44e8e6

Comment 8

[Mark Banner (:standard8)]

Attachment: Use a shared file

Ok, I didn't realise that we already had a check for build/ differing from mozilla/build otherwise I might have done this first time around.

Anyway, here's a patch to add the relevant file and use it.

Comment 9

[Mark Banner (:standard8)]

(for the other OS I'll look later once we've got TB stuff running on FF hardware, as certainly the Windows stuff needs upgrading to 2010, but we don't want to do that before getting it running).

Comment 10

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/950133af840f

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 616159 [details] [diff] [review]
The fix v2

[Triage Comment]
Currently these are effectively NPOTB and don't yet affect our production builders, however we need to get them to all places for our work on moving across the build systems. Hence I'm landing these on all the active branches.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 616844 [details] [diff] [review]
set CC,CXX inline

[Triage Comment]

Comment 13

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/releases/comm-aurora/rev/de3bbe0ad60b
http://hg.mozilla.org/releases/comm-aurora/rev/8994f54bce38
http://hg.mozilla.org/releases/comm-aurora/rev/9226555963d7
http://hg.mozilla.org/releases/comm-aurora/rev/6baac4996ddd
http://hg.mozilla.org/releases/comm-beta/rev/50a0ccf120cd
http://hg.mozilla.org/releases/comm-beta/rev/362cf441d07f
http://hg.mozilla.org/releases/comm-beta/rev/bea57976ff98
http://hg.mozilla.org/releases/comm-beta/rev/85eaa117917d
http://hg.mozilla.org/releases/comm-beta/rev/47a7b40f9e66

Comment 14

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/releases/comm-esr10/rev/08bd02a81a24
http://hg.mozilla.org/releases/comm-esr10/rev/caa8f67c3d1e
http://hg.mozilla.org/releases/comm-esr10/rev/9f3b078d7fc7
http://hg.mozilla.org/releases/comm-esr10/rev/ad6ee9e51d3c