6.76 KB, image/png
23.71 KB, image/png
9.41 KB, image/png
14.27 KB, image/png
13.67 KB, image/png
4.91 KB, patch
|Details | Diff | Splinter Review|
Created attachment 616223 [details] Screenshot of the download icon on Windows XP The green on dark grey colors for the icon progressbar are problematic. There's not enough contrast to be able to distinguish them if someone has problems seeing the green color. I have deuteranopia personally and cannot see the progressbar without moving my head close to the screen.
yes, the contrast doesn't help much
Status: UNCONFIRMED → NEW
Ever confirmed: true
Due to the space constraints I think we should go for a monochrome progressbar, btw, this needs design hints.
Created attachment 680232 [details] Updated Windows XP screenshot So, I just booted up Firefox on a Windows XP VM, and this is what the progress bar looks like in the button. It's significantly different from the original screenshot, and according to http://juicystudio.com/services/luminositycontrastratio.php, the contrast is string enough between the left-half of the foreground gradient, and the background. The right-half of the foreground gradient, however, fails the test. I'll see if I can correct that.
Hm - so, correction to my last - the gradients are sufficient for *large text only*, according to the contrast checker app. I'll see if I can find something that works for normal sized text - that should be sufficient for our progress bar.
Created attachment 680242 [details] [diff] [review] Patch v1 Remove the gradient from the status bar foreground and background. The paused state gradients pass the contrast test. Should we keep them, or remove the gradients for consistency?
Assignee: nobody → mconley
yes I think we should remove the gradient, or reduce it to 1px (this may still give nice effects). Maybe we could add a lighter 1px gradient at the top giving this sort of a "glass" appearance, being lighter it may also help with contrast.
something like: blue light blue 1px blue blue blue
Created attachment 680718 [details] 1px gradient (In reply to Marco Bonardo [:mak] from comment #8) > something like: > blue > light blue 1px > blue > blue > blue So, something more like this?
Created attachment 680727 [details] 1px gradient (now with more context)
Attachment #680718 - Attachment is obsolete: true
Created attachment 680731 [details] 1px gradient (50% completed download)
Attachment #680727 - Attachment is obsolete: true
Created attachment 680763 [details] Progress bar comparison
Comment on attachment 680763 [details] Progress bar comparison So, I like the 1px band for a couple reasons: - retains native color - increases contrast - doesn't look washed-out Remember that if we change the progress bar style here, we must change it also in the paused state, to be coherent. And I think also across the board for all OSes. I also think for simplicity of implementation we may specify a background color and make the gradient white with opacity, then we could just change one color across different themes.
Comment on attachment 680242 [details] [diff] [review] Patch v1 comment 13 has feedback
Created attachment 681170 [details] [diff] [review] WIP Patch 1 This removes the background gradient, and adds the 1px band for Windows 7 / XP. pinstripe and gnomestripe coming up next.
Created attachment 681179 [details] [diff] [review] WIP Patch 2 Adds 1px strip to pinstripe.
Attachment #681170 - Attachment is obsolete: true
6 years ago
Created attachment 681201 [details] [diff] [review] Patch v1
Comment on attachment 681201 [details] [diff] [review] Patch v1 Review of attachment 681201 [details] [diff] [review]: ----------------------------------------------------------------- I must admit the result overcame my expectations. Just as a reminder for people following this bug, we still need to adress bug 811469 and bug 811076 Also, we'll do a final UI review pass before releasing by default.
Attachment #681201 - Flags: review?(mak77) → review+
Thanks! Landed in mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/b04cea4ab159
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.