Closed Bug 746674 Opened 12 years ago Closed 12 years ago

Download icon progressbar hard to see for people with mono/dichromacy.


(Firefox :: Theme, defect)

Windows XP
Not set



Firefox 19


(Reporter: ferongr, Assigned: mconley)


(Blocks 1 open bug)


(Keywords: access)


(6 files, 9 obsolete files)

6.76 KB, image/png
23.71 KB, image/png
9.41 KB, image/png
14.27 KB, image/png
13.67 KB, image/png
4.91 KB, patch
: review+
Details | Diff | Splinter Review
The green on dark grey colors for the icon progressbar are problematic. There's not enough contrast to be able to distinguish them if someone has problems seeing the green color. I have deuteranopia personally and cannot see the progressbar without moving my head close to the screen.
yes, the contrast doesn't help much
Ever confirmed: true
Component: General → Theme
QA Contact: general → theme
Blocks: 726447
Keywords: access
Due to the space constraints I think we should go for a monochrome progressbar, btw, this needs design hints.
Flags: needinfo?(shorlander)
Attached image Updated Windows XP screenshot (obsolete) —
So, I just booted up Firefox on a Windows XP VM, and this is what the progress bar looks like in the button.

It's significantly different from the original screenshot, and according to, the contrast is string enough between the left-half of the foreground gradient, and the background.

The right-half of the foreground gradient, however, fails the test. I'll see if I can correct that.
Hm - so, correction to my last - the gradients are sufficient for *large text only*, according to the contrast checker app.

I'll see if I can find something that works for normal sized text - that should be sufficient for our progress bar.
Attached patch Patch v1 (obsolete) — Splinter Review
Remove the gradient from the status bar foreground and background.

The paused state gradients pass the contrast test. Should we keep them, or remove the gradients for consistency?
Assignee: nobody → mconley
Attachment #680242 - Flags: feedback?(mak77)
Attached image Progress with patch applied (obsolete) —
yes I think we should remove the gradient, or reduce it to 1px (this may still give nice effects). Maybe we could add a lighter 1px gradient at the top giving this sort of a "glass" appearance, being lighter it may also help with contrast.
something like:
light blue 1px
Attached image 1px gradient (obsolete) —
(In reply to Marco Bonardo [:mak] from comment #8)
> something like:
> blue
> light blue 1px
> blue
> blue
> blue

So, something more like this?
Attached image 1px gradient (now with more context) (obsolete) —
Attachment #680718 - Attachment is obsolete: true
Attached image 1px gradient (50% completed download) (obsolete) —
Attachment #680727 - Attachment is obsolete: true
Attached image Progress bar comparison (obsolete) —
Attachment #680243 - Attachment is obsolete: true
Attachment #680731 - Attachment is obsolete: true
Comment on attachment 680763 [details]
Progress bar comparison

So, I like the 1px band for a couple reasons:
- retains native color
- increases contrast
- doesn't look washed-out

Remember that if we change the progress bar style here, we must change it also in the paused state, to be coherent.
And I think also across the board for all OSes.

I also think for simplicity of implementation we may specify a background color and make the gradient white with opacity, then we could just change one color across different themes.
Blocks: 811076
Comment on attachment 680242 [details] [diff] [review]
Patch v1

comment 13 has feedback
Attachment #680242 - Flags: feedback?(mak77)
Attached patch WIP Patch 1 (obsolete) — Splinter Review
This removes the background gradient, and adds the 1px band for Windows 7 / XP.

pinstripe and gnomestripe coming up next.
Attachment #680232 - Attachment is obsolete: true
Attachment #680242 - Attachment is obsolete: true
Attachment #680763 - Attachment is obsolete: true
Attached image Patch on Windows 7
Attached image Patch on Windows XP
Attached patch WIP Patch 2 (obsolete) — Splinter Review
Adds 1px strip to pinstripe.
Attachment #681170 - Attachment is obsolete: true
Attached image Patch on OSX
Blocks: 811469
Attached image Patch on Ubuntu
Attached patch Patch v1Splinter Review
Attachment #681179 - Attachment is obsolete: true
Attachment #681201 - Flags: review?(mak77)
Comment on attachment 681201 [details] [diff] [review]
Patch v1

Review of attachment 681201 [details] [diff] [review]:

I must admit the result overcame my expectations.

Just as a reminder for people following this bug, we still need to adress bug 811469 and bug 811076
Also, we'll do a final UI review pass before releasing by default.
Attachment #681201 - Flags: review?(mak77) → review+
Flags: needinfo?(shorlander)
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.