746737 - Filelink URL insertion should not move the users selection point

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1)  Start a Filelink upload
2)  Start typing in the compose window, and don't stop until the upload completes

What happens?

The attachment URL gets inserted, and the user's selection is moved below it.

What's expected?

The users selection should not have changed from where they were.

This is quite disruptive to the flow of email composition.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

It used to be that the selection didn't move - but I think that regressed when I beefed up the URL insertion logic.  I don't think this is too hard a fix.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

So it turns out this isn't a problem if we're in the middle of typing a line.

If, however, the last character we typed was a newline, *then* our selection was moved.

So, new STR:

1)  Start a Filelink upload
2)  Type a few characters in the compose window, and press enter to start a new line
3)  Wait for upload to complete

What happens?

The attachment URL gets inserted, and the selection is now below the inserted URL.

What's expected?

The selection should be where the user left it - on that first newline.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Ok, one final modification to my STR - you need *two* newlines after any text in order to observe the problem.

This patch fixes the problem and adds a test.

Comment 4

[David :Bienvenu]

Comment on attachment 617054 [details] [diff] [review]
Patch v1

mozmill tests pass w/ patch...

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks!

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/a964c299bcec
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/8654fc069828