Filelink URL insertion should not move the users selection point

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 14.0
x86
All

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
STR:

1)  Start a Filelink upload
2)  Start typing in the compose window, and don't stop until the upload completes

What happens?

The attachment URL gets inserted, and the user's selection is moved below it.

What's expected?

The users selection should not have changed from where they were.

This is quite disruptive to the flow of email composition.
(Assignee)

Comment 1

5 years ago
It used to be that the selection didn't move - but I think that regressed when I beefed up the URL insertion logic.  I don't think this is too hard a fix.
Assignee: nobody → mconley
(Assignee)

Comment 2

5 years ago
So it turns out this isn't a problem if we're in the middle of typing a line.

If, however, the last character we typed was a newline, *then* our selection was moved.

So, new STR:

1)  Start a Filelink upload
2)  Type a few characters in the compose window, and press enter to start a new line
3)  Wait for upload to complete

What happens?

The attachment URL gets inserted, and the selection is now below the inserted URL.

What's expected?

The selection should be where the user left it - on that first newline.
(Assignee)

Comment 3

5 years ago
Created attachment 617054 [details] [diff] [review]
Patch v1

Ok, one final modification to my STR - you need *two* newlines after any text in order to observe the problem.

This patch fixes the problem and adds a test.
Attachment #617054 - Flags: review?(dbienvenu)

Comment 4

5 years ago
Comment on attachment 617054 [details] [diff] [review]
Patch v1

mozmill tests pass w/ patch...
Attachment #617054 - Flags: review?(dbienvenu)
Attachment #617054 - Flags: review+
Attachment #617054 - Flags: approval-comm-aurora+
(Assignee)

Comment 5

5 years ago
Thanks!

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/a964c299bcec
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/8654fc069828
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird13: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.