746783 - "Open Containing Folder" doesn't appear in context menu of downloads

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, enhancement, P2)

Description

[Daniel C]

Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120418 Firefox/14.0a1

Given that the magnifying glass is a small target, and that is not entirely obvious what it does at a glance (synonymous with search, which doesn't really describe what I want to do because I know that it's in the Downloads folder, I just want to go there), I suggest that the option also be included in the context menu. The target area for the context menu is much larger, and the old download manager had this option.

I would also put "Open" back in the context menu so that you can do everything from the context menu, but this is less important as the visual feedback from hovering is probably obvious enough that clicking an item will open it.

Comment 1

[Dave Herman [:dherman]]

In case it's a useful data point, I didn't notice the magnifying glass until I found this bug.

Dave

Comment 2

[Marco Bonardo [:mak]]

We were evaluating to replace the magnifier icon with an open folder icon.

Comment 3

[Marco Bonardo [:mak]]

not toolkit, no.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Interestingly, Open Containing Folder IS in the menu for active downloads...

Comment 6

[Mihail Daskalov]

In case it's a useful data point, I didn't notice the magnifying glass until I found this bug. +1

In the 'Show All Downloads' window I still cannot find it.

I suggest, that it is included in the Context menu, and also to allow the column with the downloaded location to be shown (via Show columns).

Comment 7

[Marco Bonardo [:mak]]

the Library (show all downloads) view will be completely replaced.

Comment 8

[u428464]

I think "Open Containing Folder" should appear in the context menu and be also accessible through the magnifying glass (to be replaced by something more adequate like a folder icon or an eye as on some of Shorlander's mockups).

Comment 9

[Mihail Daskalov]

I think Platform should be changed to All. This concerns at least Windows build in addition to Linux.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Should this be added to our release blocker list, since it's a feature regression from the old window?

Comment 12

[Marco Bonardo [:mak]]

The old DM didn't have a dedicated primary ui button to go to the containing folder, so I don't consider this a feature regression.
It wouldn't hurt, but we explicitly worked toward removing menus redundancies and this would go opposite direction.
It is a design choice, we need UX decision.

Comment 13

[Stephen Horlander [:shorlander]]

It makes sense to add this to the context menu with the rest of the direct item actions. The icon is just supposed to cover the primary use case for each item in the various states, so I don't think a slight redundancy here is a problem.

Comment 14

[Marco Bonardo [:mak]]

soft blocker, looks like a quite often requested feature.

Comment 15

[Marco Bonardo [:mak]]

the option should be added both to the panel and the Library view contextual menus.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 19

[Asaf Romano (gone)]

Comment on attachment 696728 [details] [diff] [review]
Patch v1

What about the panel?

Comment 20

[Asaf Romano (gone)]

Comment on attachment 696728 [details] [diff] [review]
Patch v1

Er, never mind :)

Comment 21

[Mike Conley (:mconley) (:⚙️)]

(In reply to Mano from comment #20)
> Comment on attachment 696728 [details] [diff] [review]
> Patch v1
> 
> Er, never mind :)

Thanks Mano!

Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/6727b9f56848

Comment 22

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/6727b9f56848