747165 - Chat icons not shown on Aero in small icon mode

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

When the toolbar is in small icons mode the icons aren't shown because the XP selectors are stronger.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Fix

Adding !important solves this issue. I also fixed a copy n paste error which also made the disabled Add buddy icon disappear.

Mike, I hope it's okay to ask you for review. You're so a fast reviewer :)

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 616738 [details] [diff] [review]
Fix

Review of attachment 616738 [details] [diff] [review]:
-----------------------------------------------------------------

Works as advertised, and code looks good.

Thanks Richard,

-Mike

Comment 3

[Richard Marti (:Paenglab)]

Mike, thank you for the fast review.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Richard,

No problem!  Thanks for your great work!

-Mike

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 616738 [details] [diff] [review]
Fix

[Approval Request Comment]
The same issue exists also on Aurora. To work correctly this should also land there.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/ecdc43b5164e

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 616738 [details] [diff] [review]
Fix

Removing the approval-comm-aurora flag as I think we should rather take the patch from bug 735702 (which includes a fix for the same issue, see bug 735702 comment 21) to aurora if we still want to fix icon stuff there.