Closed Bug 747165 Opened 8 years ago Closed 8 years ago

Chat icons not shown on Aero in small icon mode

Categories

(Thunderbird :: Instant Messaging, defect)

All
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 14.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

When the toolbar is in small icons mode the icons aren't shown because the XP selectors are stronger.
Attached patch FixSplinter Review
Adding !important solves this issue. I also fixed a copy n paste error which also made the disabled Add buddy icon disappear.

Mike, I hope it's okay to ask you for review. You're so a fast reviewer :)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #616738 - Flags: review?(mconley)
Comment on attachment 616738 [details] [diff] [review]
Fix

Review of attachment 616738 [details] [diff] [review]:
-----------------------------------------------------------------

Works as advertised, and code looks good.

Thanks Richard,

-Mike
Attachment #616738 - Flags: review?(mconley) → review+
Mike, thank you for the fast review.
Keywords: checkin-needed
Richard,

No problem!  Thanks for your great work!

-Mike
Comment on attachment 616738 [details] [diff] [review]
Fix

[Approval Request Comment]
The same issue exists also on Aurora. To work correctly this should also land there.
Attachment #616738 - Flags: approval-comm-aurora?
http://hg.mozilla.org/comm-central/rev/ecdc43b5164e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 616738 [details] [diff] [review]
Fix

Removing the approval-comm-aurora flag as I think we should rather take the patch from bug 735702 (which includes a fix for the same issue, see bug 735702 comment 21) to aurora if we still want to fix icon stuff there.
Attachment #616738 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.