Chat icons not shown on Aero in small icon mode

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 14.0
All
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When the toolbar is in small icons mode the icons aren't shown because the XP selectors are stronger.
(Assignee)

Comment 1

5 years ago
Created attachment 616738 [details] [diff] [review]
Fix

Adding !important solves this issue. I also fixed a copy n paste error which also made the disabled Add buddy icon disappear.

Mike, I hope it's okay to ask you for review. You're so a fast reviewer :)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #616738 - Flags: review?(mconley)
Comment on attachment 616738 [details] [diff] [review]
Fix

Review of attachment 616738 [details] [diff] [review]:
-----------------------------------------------------------------

Works as advertised, and code looks good.

Thanks Richard,

-Mike
Attachment #616738 - Flags: review?(mconley) → review+
(Assignee)

Comment 3

5 years ago
Mike, thank you for the fast review.
Keywords: checkin-needed
Richard,

No problem!  Thanks for your great work!

-Mike
(Assignee)

Comment 5

5 years ago
Comment on attachment 616738 [details] [diff] [review]
Fix

[Approval Request Comment]
The same issue exists also on Aurora. To work correctly this should also land there.
Attachment #616738 - Flags: approval-comm-aurora?
http://hg.mozilla.org/comm-central/rev/ecdc43b5164e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Keywords: checkin-needed
Comment on attachment 616738 [details] [diff] [review]
Fix

Removing the approval-comm-aurora flag as I think we should rather take the patch from bug 735702 (which includes a fix for the same issue, see bug 735702 comment 21) to aurora if we still want to fix icon stuff there.
Attachment #616738 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.