Webapps installer follow-ups

RESOLVED FIXED in Firefox 14

Status

Firefox Graveyard
Web Apps
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

Trunk
Firefox 14
All
Windows 7
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 616772 [details] [diff] [review]
Patch

Nits from changes that got out of sync between the installer/uninstaller work
Attachment #616772 - Flags: superreview?(tabraldes)
(Assignee)

Comment 1

5 years ago
Comment on attachment 616772 [details] [diff] [review]
Patch

oops wrong review field
Attachment #616772 - Flags: superreview?(tabraldes) → review?(tabraldes)
(Assignee)

Comment 2

5 years ago
Created attachment 616792 [details] [diff] [review]
Patch v2

Patch v2 with more changes (changed WebappRT -> Webapp in uninstaller, removed branding, updated name of shortcuts_log.ini).

Shortcut removal still doesn't work
Attachment #616772 - Attachment is obsolete: true
Attachment #616772 - Flags: review?(tabraldes)
(Assignee)

Comment 3

5 years ago
Created attachment 616804 [details] [diff] [review]
Patch v3

Changed Shortcut to Shortcut1. Untested.
Attachment #616792 - Attachment is obsolete: true
(In reply to Felipe Gomes (:felipe) from comment #3)
> Created attachment 616804 [details] [diff] [review]
> Patch v3
> 
> Changed Shortcut to Shortcut1. Untested.

It turns out it should be Shortcut0.  I tested the patch and everything seems to work (as long as you change Shortcut1 to Shortcut0).  I'd give r+ but I'm not a peer of any module.
(In reply to Tim Abraldes from comment #4)
> I tested the patch and everything
> seems to work (as long as you change Shortcut1 to Shortcut0).  I'd give r+
> but I'm not a peer of any module.

Tim: how about you give feedback+, and then felipe can figure out who should do the review.
Comment on attachment 616804 [details] [diff] [review]
Patch v3

Review of attachment 616804 [details] [diff] [review]:
-----------------------------------------------------------------

r=me as long as you change this to write "Shortcut0" instead of "Shortcut1" to shortcuts_log.ini
Attachment #616804 - Flags: review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ebec7bc561e1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Summary: Windows installer follow-ups → Webapps installer follow-ups
Target Milestone: --- → Firefox 14
Felipe - Is there anything needed here to be verified? If so, what should I verify? It looks like underlying code changes for cleanup.
Whiteboard: [qa-]

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.