747205 - Webapps installer follow-ups

Status: RESOLVED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Nits from changes that got out of sync between the installer/uninstaller work

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 616772 [details] [diff] [review]
Patch

oops wrong review field

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v2

Patch v2 with more changes (changed WebappRT -> Webapp in uninstaller, removed branding, updated name of shortcuts_log.ini).

Shortcut removal still doesn't work

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v3

Changed Shortcut to Shortcut1. Untested.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Felipe Gomes (:felipe) from comment #3)
> Created attachment 616804 [details] [diff] [review]
> Patch v3
> 
> Changed Shortcut to Shortcut1. Untested.

It turns out it should be Shortcut0.  I tested the patch and everything seems to work (as long as you change Shortcut1 to Shortcut0).  I'd give r+ but I'm not a peer of any module.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to Tim Abraldes from comment #4)
> I tested the patch and everything
> seems to work (as long as you change Shortcut1 to Shortcut0).  I'd give r+
> but I'm not a peer of any module.

Tim: how about you give feedback+, and then felipe can figure out who should do the review.

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 616804 [details] [diff] [review]
Patch v3

Review of attachment 616804 [details] [diff] [review]:
-----------------------------------------------------------------

r=me as long as you change this to write "Shortcut0" instead of "Shortcut1" to shortcuts_log.ini

Comment 7

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/mozilla-central/rev/ebec7bc561e1

Comment 8

[Jason Smith [:jsmith]]

Felipe - Is there anything needed here to be verified? If so, what should I verify? It looks like underlying code changes for cleanup.