747377 - Force direct 2d enabled to ignore block listed drivers

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Brian R. Bondy [:bbondy]]

If the user is in metro mode we should have the same functionality as: 
gfx.direct2d.force-enabled

Since preferences may be shared between both desktop and metro, instead of turning it on via a default pref, it would be best to do the check dynamically to see if we are in metro mode and then have the same effect.

This task will help us determine if we need to support block listed drivers on Windows 8 Metro.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Forced on now.  We should do another installer once we get that suspend crash fixed to get feedback on this.

Comment 2

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/projects/elm/rev/a554671030b0

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2.

We would like to land this on m-c to prepare for the Metro merge.

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: Patch v3

- Added caching of the result because this is now called frequently from other gfx code
- Made it a static member function

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 625197 [details] [diff] [review]
Patch v3

Review of attachment 625197 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +403,5 @@
> +  if (alreadyChecked) {
> +    return isMetro;
> +  }
> +
> +  HMODULE user32DLL = LoadLibraryW(L"user32.dll");

Hrm, is there any danger here of DLL injection?

Comment 6

[Brian R. Bondy [:bbondy]]

No. user32 is a Known DLL so it will be loaded from the system32 directory.

See here:
> HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\KnownDLLs

Comment 7

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/712b0e70632c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/712b0e70632c