Force direct 2d enabled to ignore block listed drivers

RESOLVED FIXED in mozilla17

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla17
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: completed-elm)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
If the user is in metro mode we should have the same functionality as: 
gfx.direct2d.force-enabled

Since preferences may be shared between both desktop and metro, instead of turning it on via a default pref, it would be best to do the check dynamically to see if we are in metro mode and then have the same effect.

This task will help us determine if we need to support block listed drivers on Windows 8 Metro.
(Assignee)

Comment 1

5 years ago
Created attachment 617012 [details] [diff] [review]
Patch v1.

Forced on now.  We should do another installer once we get that suspend crash fixed to get feedback on this.
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/projects/elm/rev/a554671030b0

Updated

5 years ago
Blocks: 747347
(Assignee)

Comment 3

5 years ago
Created attachment 622843 [details] [diff] [review]
Patch v2.

We would like to land this on m-c to prepare for the Metro merge.
Attachment #617012 - Attachment is obsolete: true
Attachment #622843 - Flags: review?(bas.schouten)
(Assignee)

Comment 4

5 years ago
Created attachment 625197 [details] [diff] [review]
Patch v3

- Added caching of the result because this is now called frequently from other gfx code
- Made it a static member function
Attachment #622843 - Attachment is obsolete: true
Attachment #622843 - Flags: review?(bas.schouten)
Attachment #625197 - Flags: review?(bas.schouten)
Comment on attachment 625197 [details] [diff] [review]
Patch v3

Review of attachment 625197 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +403,5 @@
> +  if (alreadyChecked) {
> +    return isMetro;
> +  }
> +
> +  HMODULE user32DLL = LoadLibraryW(L"user32.dll");

Hrm, is there any danger here of DLL injection?
Attachment #625197 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 6

5 years ago
No. user32 is a Known DLL so it will be loaded from the system32 directory.

See here:
> HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\KnownDLLs
(Assignee)

Updated

5 years ago
Whiteboard: completed-elm
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/712b0e70632c
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/712b0e70632c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.