Closed Bug 747377 Opened 10 years ago Closed 10 years ago

Force direct 2d enabled to ignore block listed drivers

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

(Whiteboard: completed-elm)

Attachments

(1 file, 2 obsolete files)

If the user is in metro mode we should have the same functionality as: 
gfx.direct2d.force-enabled

Since preferences may be shared between both desktop and metro, instead of turning it on via a default pref, it would be best to do the check dynamically to see if we are in metro mode and then have the same effect.

This task will help us determine if we need to support block listed drivers on Windows 8 Metro.
Attached patch Patch v1. (obsolete) — Splinter Review
Forced on now.  We should do another installer once we get that suspend crash fixed to get feedback on this.
Blocks: elm-merge
Attached patch Patch v2. (obsolete) — Splinter Review
We would like to land this on m-c to prepare for the Metro merge.
Attachment #617012 - Attachment is obsolete: true
Attachment #622843 - Flags: review?(bas.schouten)
Attached patch Patch v3Splinter Review
- Added caching of the result because this is now called frequently from other gfx code
- Made it a static member function
Attachment #622843 - Attachment is obsolete: true
Attachment #622843 - Flags: review?(bas.schouten)
Attachment #625197 - Flags: review?(bas.schouten)
Comment on attachment 625197 [details] [diff] [review]
Patch v3

Review of attachment 625197 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +403,5 @@
> +  if (alreadyChecked) {
> +    return isMetro;
> +  }
> +
> +  HMODULE user32DLL = LoadLibraryW(L"user32.dll");

Hrm, is there any danger here of DLL injection?
Attachment #625197 - Flags: review?(bas.schouten) → review+
No. user32 is a Known DLL so it will be loaded from the system32 directory.

See here:
> HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\KnownDLLs
Whiteboard: completed-elm
https://hg.mozilla.org/mozilla-central/rev/712b0e70632c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.