747429 - Make it possible to start a remote debugger only in a new chrome window

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

New process would make sense only for chrome debugging. In all other cases, a new window is nicer for tons of reasons.

Comment 1

[Dave Camp (:dcamp)]

Should this bug also include a debuggee/tab selection UI in this bug?

Comment 2

[Victor Porof [:vporof][:vp]]

(In reply to Dave Camp (:dcamp) from comment #1)
> Should this bug also include a debuggee/tab selection UI in this bug?

Why should it? We could just say "One debugger per tab. You pop it in a new window, it's the same debugger for the same debuggee. Want to debug another tab? Open a new debugger".

Comment 3

[Dave Camp (:dcamp)]

I misremembered this bug as being for general remote fennec/b2g debugging - I need to specify how to connect to the phone I intend to debug, and which of its debuggees I'm interested in.

I guess we could just always debug the currently-visible tab, but we do still need some way to specify the debuggee to connect to.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Dave Camp (:dcamp) from comment #3)
> I misremembered this bug as being for general remote fennec/b2g debugging -
> I need to specify how to connect to the phone I intend to debug, and which
> of its debuggees I'm interested in.
> 
> I guess we could just always debug the currently-visible tab, but we do
> still need some way to specify the debuggee to connect to.

Filed bug 748927 for this.

Comment 5

[Victor Porof [:vporof][:vp]]

Note: we shouldn't be able to open a remote debugger in a new firefox instance. A simple new window should suffice.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1

WIP

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v2

Works!

Comment 8

[Victor Porof [:vporof][:vp]]

Comment on attachment 619050 [details] [diff] [review]
v2

I herd Rob has free time on his hands.

Comment 9

[Rob Campbell [:rc] (:robcee)]

(In reply to Victor Porof from comment #8)
> Comment on attachment 619050 [details] [diff] [review]
> v2
> 
> I herd Rob has free time on his hands.

hey, thanks, buddy. I'll get right on this.

Comment 10

[Rob Campbell [:rc] (:robcee)]

Attachment: v2+x

augh

Comment 11

[Victor Porof [:vporof][:vp]]

Attachment: v2+xx

Small changes, typos.

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 619281 [details] [diff] [review]
v2+xx

+   * Creates and initializes the widgets containing the remote debugger UI.
+   */
+  _create: function DP__create() {

I think in this method you should explicitly remove the toolbar's close button. It doesn't really make sense to have it there when in an external window. Also, it doesn't work.

Patch looks good, tests pass on my machine.

R+ with the above change.

Comment 13

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #12)
> Comment on attachment 619281 [details] [diff] [review]
> v2+xx
> 
> +   * Creates and initializes the widgets containing the remote debugger UI.
> +   */
> +  _create: function DP__create() {
> 
> I think in this method you should explicitly remove the toolbar's close
> button. It doesn't really make sense to have it there when in an external
> window. Also, it doesn't work.
> 
> Patch looks good, tests pass on my machine.
> 
> R+ with the above change.

Well not really in that method, it needs to be in the content js, not the jsm, because that's just a simple iframe wrapper.

Also, I guess this applies in the chrome debugging case as well, right?

Comment 14

[Victor Porof [:vporof][:vp]]

Attachment: v3

Made the change.

Comment 15

[Victor Porof [:vporof][:vp]]

Attachment: v3.1

Rebased.

Comment 16

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/5e3d7eccb832

Comment 17

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5e3d7eccb832