The default bug view has changed. See this FAQ.

Create a separate way to start a chrome debugger

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Component: Developer Tools: Inspector → Developer Tools: Debugger
QA Contact: developer.tools.inspector → developer.tools.debugger
(Assignee)

Comment 1

5 years ago
Created attachment 618685 [details] [diff] [review]
v1
Attachment #618685 - Flags: review?(past)
Comment on attachment 618685 [details] [diff] [review]
v1

Review of attachment 618685 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1064,4 @@
>  pref("devtools.debugger.remote-enabled", false);
>  pref("devtools.debugger.remote-host", "localhost");
>  pref("devtools.debugger.remote-port", 6000);
> +pref("devtools.debugger.chrome-enabled", false);

No need for that, we already have devtools.chrome.enabled.

::: browser/locales/en-US/chrome/browser/devtools/debugger.dtd
@@ +16,5 @@
>  <!ENTITY remoteDebuggerMenu.label    "Remote Debugger">
>  
> +<!-- LOCALIZATION NOTE (firefoxDebuggerMenu.label): This is the label for the
> +  -  application menu item that opens the firefox debugger UI. -->
> +<!ENTITY firefoxDebuggerMenu.label   "Firefox Debugger">

Browser Debugger I believe was the consensus in the room.
Attachment #618685 - Flags: review?(past) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 618729 [details] [diff] [review]
v2
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 4

5 years ago
Created attachment 618736 [details] [diff] [review]
v2.1

Using "chromeDebugger" ids instead of "firefoxDebugger" for consistency.
(Assignee)

Comment 5

5 years ago
A test fails.
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 6

5 years ago
(In reply to Victor Porof from comment #5)
> A test fails.

Nope, I had my mq messed up.
Whiteboard: [land-in-fx-team]
(Assignee)

Updated

5 years ago
Blocks: 747429
also, this appears to depend on the remote debugger patches.
(Assignee)

Comment 8

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> also, this appears to depend on the remote debugger patches.

...which landed
https://hg.mozilla.org/integration/fx-team/rev/77ee439cc506
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Sorry, I had to back this out because of a merge conflict with m-c.

https://hg.mozilla.org/integration/fx-team/rev/90a1323daf91

We needed to merge m-c to fx-team because we had to backout patches causing a Ts regression:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d871849ac3a3&tochange=0f8ea3826bf7
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/dc3bd5eab128
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/dc3bd5eab128
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.