749222 - Create a separate way to start a chrome debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 618685 [details] [diff] [review]
v1

Review of attachment 618685 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1064,4 @@
>  pref("devtools.debugger.remote-enabled", false);
>  pref("devtools.debugger.remote-host", "localhost");
>  pref("devtools.debugger.remote-port", 6000);
> +pref("devtools.debugger.chrome-enabled", false);

No need for that, we already have devtools.chrome.enabled.

::: browser/locales/en-US/chrome/browser/devtools/debugger.dtd
@@ +16,5 @@
>  <!ENTITY remoteDebuggerMenu.label    "Remote Debugger">
>  
> +<!-- LOCALIZATION NOTE (firefoxDebuggerMenu.label): This is the label for the
> +  -  application menu item that opens the firefox debugger UI. -->
> +<!ENTITY firefoxDebuggerMenu.label   "Firefox Debugger">

Browser Debugger I believe was the consensus in the room.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v2

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v2.1

Using "chromeDebugger" ids instead of "firefoxDebugger" for consistency.

Comment 5

[Victor Porof [:vporof][:vp]]

A test fails.

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Victor Porof from comment #5)
> A test fails.

Nope, I had my mq messed up.

Comment 7

[Rob Campbell [:rc] (:robcee)]

also, this appears to depend on the remote debugger patches.

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> also, this appears to depend on the remote debugger patches.

...which landed

Comment 9

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/77ee439cc506

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Sorry, I had to back this out because of a merge conflict with m-c.

https://hg.mozilla.org/integration/fx-team/rev/90a1323daf91

We needed to merge m-c to fx-team because we had to backout patches causing a Ts regression:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d871849ac3a3&tochange=0f8ea3826bf7

Comment 11

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/dc3bd5eab128

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/dc3bd5eab128