747567 - why has the pref defaults directory been changed from "defaults\pref" to "defaults\preferences" in 14.0a1 (2012-04-20)

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[al_9x]

this breaks user defined defaults, then you have to spend time figuring what happened

Comment 1

[Matthias Versen [:Matti]]

looks like a change from bug 746156

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Yup, that's right, this is a change from bug 746156.

I made the change to isolate the new webapp runtime from Firefox's preferences and to eliminate a set of hacks we previously had to employ to load the runtime's preferences.

If I had left Firefox's preferences in defaults/pref/, which is the GRE default preferences directory, then they would have continued to load for the runtime, causing problems for it like the one that required a special hack to make the runtime ignore Firefox's browser.hiddenWindowChromeURL preference. And we would have had to maintain a set of hacks just to load the runtime's preferences in the first place (without Firefox also loading them, but making sure they override Firefox's preferences).

With Firefox's preferences in defaults/preferences/, which is the xulapp default preferences directory (i.e. where preferences for xulapps like Firefox are designed to go), and the runtime's preferences in webapprt/defaults/preferences/, Firefox continues to load its preferences, but the runtime stops loading Firefox's preferences and instead only loads its own.

Comment 3

[Benjamin Smedberg]

Please reopen if we're missing something, but I don't think there is a bug here.

Comment 4

[al_9x]

22.0a1 is not reading defaults\preferences, bug or another change?

Comment 5

[Benjamin Smedberg]

Another bug relating to the recent landing of metro. glandium would know the status of that.

Comment 6

[Mike Hommey [:glandium]]

yes, preferences are now in defaults/pref for GRE and browser/defaults/preferences for the browser.