Closed Bug 747645 Opened 13 years ago Closed 13 years ago

move webapp-uninstaller.properties to browser/locales/ to make it easier to localize

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P1)

Product:
Firefox Graveyard
Component:
Webapp Runtime
Type:
defect

Tracking

(blocking-kilimanjaro:-)

Status:
RESOLVED FIXED
Milestone:
Firefox 15
Project Flags:
blocking-kilimanjaro -

People

(Reporter: myk, Assigned: myk)

Details

(Whiteboard: [blocking-webrtdesktop1+], [qa-])

Attachments

(1 file)

patch v1: moves file
2.44 KB, patch
Felipe
: review+
myk
: checkin+
Details | Diff | Splinter Review
webapp-uninstaller.properties landed in webapprt/locales/en-US/webapp-uninstaller/, but the l10n build infrastructure is not yet set up to handle localization of files in that directory, so we should move it to browser/locales/en-US/webapprt/.
Whiteboard: [marketplace-beta-]
Priority: -- → P1
Whiteboard: [marketplace-beta-] → [marketplace-beta-] [blocking-webrtdesktop1+]
Target Milestone: --- → M1
Whiteboard: [marketplace-beta-] [blocking-webrtdesktop1+] → [blocking-webrtdesktop1+]
blocking-kilimanjaro: --- → ?
blocking-kilimanjaro: ? → -
Component: Desktop Runtime → Webapp Runtime
Product: Web Apps → Firefox
Target Milestone: M1 → Firefox 15
Assignee: nobody → myk
I think this'll work but haven't tested it yet.
Comment on attachment 628531 [details] [diff] [review] patch v1: moves file Tested; it works! Felipe: this is a straightforward move of one file from webapprt/ to browser/, for localizers whose toolchains look for locale files in the latter but not the former, which is a much simpler fix than updating those toolchains.
Attachment #628531 - Flags: review?(felipc)
Attachment #628531 - Flags: review?(felipc) → review+
Summary: move webapp-uninstaller.properties to browser/locales/en-US/webapprt/ to make it easier to localize → move webapp-uninstaller.properties to browser/locales/ to make it easier to localize
Comment on attachment 628531 [details] [diff] [review] patch v1: moves file https://hg.mozilla.org/integration/mozilla-inbound/rev/3b996074778e
Attachment #628531 - Attachment description: work in progress → patch v1: moves file
Attachment #628531 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/3b996074778e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [blocking-webrtdesktop1+] → [blocking-webrtdesktop1+], [qa-]
Flags: in-moztrap-
QA Contact: desktop-runtime → jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: