747681 - Rotation breaks content window with targetSdkVersion=14

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (04/21) - Raw log

Rotations from portrait to landscape kill Gecko on ICS with the Galaxy SII

See video: http://www.youtube.com/watch?v=34v8dZvU7G8&hd=1

There's nothing too useful in the log.

Nominating because ICS is being pushed to the SII as of last week.

--
Nightly (04/21)
Samsung Galaxy SII (Android 4.0.3)

Comment 1

[Aaron Train [:aaronmt]]

Chris/Kats, happy to take a debug build with log output for testing like last time this happened

Comment 2

[Aaron Train [:aaronmt]]

Happens on the Galaxy Nexus too.

Comment 3

[Martijn Wargers (dead)]

Regression from bug 732016?

Comment 4

[Aaron Train [:aaronmt]]

(Not really killing Gecko, but entire content area for each page is completely white with no way to recover. Things like the Tab Menu icon are removed, browser becomes unusable).

Comment 5

[Joe Drew (not getting mail)]

I backed out bug 732016 and it didn't fix this bug. I'll keep looking into it.

Comment 6

[Joe Drew (not getting mail)]

The first bad revision is:
changeset:   91988:7ecd07342540
user:        Matt Brubeck <[e-mail]>
date:        Thu Apr 19 12:28:13 2012 -0700
summary:     Bug 746703 - Set targetSdkVersion to 14 in AndroidManifest.xml to disable legacy menu button [r=blassey, a=blocking-fennec]

Gonna test a build with this backed out.

Comment 7

[Joe Drew (not getting mail)]

Yup: https://hg.mozilla.org/integration/mozilla-inbound/rev/9daee30907ea

Comment 9

[Paul Feher]

Verified/fixed on:
Nightly Fennec 15.0a1 (2012-04-25)
Device: Galaxy Nexus (Android 4.0.2), HTC Desire Z (Android 2.3.3)

Comment 10

[Matt Brubeck (:mbrubeck)]

Can anyone test if this build from bug 746703 comment 18 fixes the problem?
https://people.mozilla.com/~mbrubeck/fennec-746703-b.apk

Comment 11

[Aaron Train [:aaronmt]]

The build above in comment #10 specifying hardwareAccelerated with false is not valid overrode with the forced declaration of targetSDK 14 as it reintroduces this bug.

Tested with a Galaxy Nexus (Android 4.0.4)

Comment 12

[Matt Brubeck (:mbrubeck)]

As far as I can tell this is not caused by hardware acceleration; see bug 746703 comment 23 for details.

Comment 13

[Robert Kaiser]

(In reply to Joe Drew (:JOEDREW!) from comment #7)
> Yup: https://hg.mozilla.org/integration/mozilla-inbound/rev/9daee30907ea

That backout didn't stick but is listed as the fix here. http://hg.mozilla.org/releases/mozilla-aurora/file/bac25b8ea4e7/mobile/android/base/AndroidManifest.xml.in#l13 and http://hg.mozilla.org/mozilla-central/file/f2b2b99108a2/mobile/android/base/AndroidManifest.xml.in#l13 still have 14 set as the version.

https://crash-stats.mozilla.com/report/list?signature=libdvm.so%400x50a4e&version=FennecAndroid%3A14.0b1 is pretty high up on the topcrash list of 14.0b1 and is listed as one signatures of the dupe-to-here bug 747799, so we need to be clear on what's up with that.

Joe, Matt, can you clear up what's going on here?

Comment 14

[Matt Brubeck (:mbrubeck)]

(In reply to Robert Kaiser (:[e-mail]) from comment #13)
> (In reply to Joe Drew (:JOEDREW!) from comment #7)
> > Yup: https://hg.mozilla.org/integration/mozilla-inbound/rev/9daee30907ea
> 
> That backout didn't stick but is listed as the fix here.

This was ultimately fixed by adding "screenSize" to android:configChanges 
(bug 746703 comment 24) before re-landing bug 746703:
http://hg.mozilla.org/mozilla-central/rev/b89b6430e4bf
https://hg.mozilla.org/releases/mozilla-aurora/rev/88982d73f135

> https://crash-stats.mozilla.com/report/list?signature=libdvm.
> so%400x50a4e&version=FennecAndroid%3A14.0b1 is pretty high up on the
> topcrash list of 14.0b1 and is listed as one signatures of the dupe-to-here
> bug 747799, so we need to be clear on what's up with that.

That bug should not be duped to this one.  This bug was not a crash.