747697 - Consider blocking the AdobePDFViewerNPAPI.plugin ("Adobe Acrobat NPAPI Plug-in")

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Recent Acrobat updates have installed an AdobePDFViewerNPAPI.plugin that is apparently incompatible with Camino but which pluginHost still happily loads :P

See bug 746950 and the rapidly-growing http://forums.mozillazine.org/viewtopic.php?f=12&t=2459753 thread.

Can we blocklist this plug-in without breaking the ability for other PDF plug-ins to load (and, more importantly, for pluginHost to let it load)?  ISTR Stuart found problems trying to disable just the JEP: bug 670718 comment 4

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Patch, v0.9

This patch (which requires the patch in bug 667441 and either a] deleting pluginreg.dat or b] the patch from bug 740620) should do it.

The caveat is that we'd need plenty of testing to see whether other PDF plug-ins will still load (and, of course, to fix the other two bugs).

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Blergh, I'm so rusty with Bugzilla :/

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #1)
> The caveat is that we'd need plenty of testing to see whether other PDF
> plug-ins will still load (and, of course, to fix the other two bugs).

We should test both first-run and second run, in case Gecko might choose something different if its prior first-choice plug-in is *already* disabled/blocked.

Comment 4

[philippe (part-time)]

A patched build (including the bug 667441 patch) happily blocks the Adobe plugin. The Shubert 2.3.x PDF plugin loads without problems (or without new problems… ?) afaict.

10.7.3, multiple runs, including a necessary pluginreg.dat tossing exercise.

I wonder if we should leave the door open for a possible future update to that plugin ? The current version (10.1.3) appears br0ken in Firefox 10 & 11 (blank pages, same as Camino), and doesn't load at all in Opera 11.62.

Comment 5

[Stuart Morgan]

I wouldn't hold your breath on this plugin ever working in Camino:
https://mail.mozilla.org/pipermail/plugin-futures/2012-March/000512.html
Given that they are using the CA drawing model, even if they fix bizarre issues like only working in 64-bit they are unlikely to port back to other drawing models.

(Sorry I'm behind on these plugin blocking reviews; I'll get to them all this week.)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 617275 [details] [diff] [review]
Patch, v0.9

(In reply to Stuart Morgan from comment #5)
> I wouldn't hold your breath on this plugin ever working in Camino:
> https://mail.mozilla.org/pipermail/plugin-futures/2012-March/000512.html
> Given that they are using the CA drawing model, even if they fix bizarre
> issues like only working in 64-bit they are unlikely to port back to other
> drawing models.
> 
> (Sorry I'm behind on these plugin blocking reviews; I'll get to them all
> this week.)

In that case, and given philippe's successful testing, tossing this in the sr? queue, too.  Obviously the XXX comment is superfluous now and should go away.

(I assume we do want to do this, given Adobe is likely to try to reinstall the plug-in on next run of Reader or next Reader update.)

Comment 7

[Stuart Morgan]

Comment on attachment 617275 [details] [diff] [review]
Patch, v0.9

sr=smorgan

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/34bda6d84a1a

This obviously won't start working until bug 667441 and friends land, but I'm trying to clear the self-contained patches out of my tree first ;-)