Created attachment 617314 [details]
mojibake in chat context menu
User Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:22.214.171.124) Gecko/20120306 Firefox/3.6.28
Build ID: 20120306064154
Steps to reproduce:
1. Open chat tab.
2. Connect twitter account.
3. Right click individual tweet to show its context menu.
Only the menus of twitter actions (retweet, reply, follow, ... ) has mojibake.
It seems that the localized UTF-8 strings are not properly handled.
I'm a bit confused by this bug report, as:
- I've tried to replace the en-US strings with strings containing UTF8 characters in my debug build, and these strings were displayed correctly.
- I've tried to find the ja translation of these strings, but http://hg.mozilla.org/l10n-central/ja/file/tip/chat/twitter.properties doesn't exist (I've checked the URL with the French locale, and http://hg.mozilla.org/l10n-central/fr/file/tip/chat/twitter.properties#l20 does exist).
I've tested on Aurora build. (We haven't updated l10n-central.)
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20120422 Thunderbird/13.0a2
Tooltips and options are displayed correctly.
Created attachment 617456 [details] [diff] [review]
I couldn't reproduce with a string containing French non ASCII characters, but I can reproduce using the strings in the ja localized file.
It's caused by a trivial type error in the idl interface.
Thanks for reporting this!
Comment on attachment 617456 [details] [diff] [review]
This change looks fine, thanks for fixing it Florian.
Drive-by comment here - should the UUID for that IDL have been changed?
(In reply to Mike Conley (:mconley) from comment #6)
> Drive-by comment here - should the UUID for that IDL have been changed?
I don't think Thunderbird cares since we haven't turned this on, but Instantbird might...
(In reply to David :Bienvenu from comment #7)
> (In reply to Mike Conley (:mconley) from comment #6)
> > Drive-by comment here - should the UUID for that IDL have been changed?
> I don't think Thunderbird cares since we haven't turned this on, but
> Instantbird might...
I've never applied that rule for Instantbird as I'm not aware of any binary add-on using our xpcom interfaces.
Looks like this was pushed to aurora earlier today: