Windows constants for js-ctypes (Chrome Workers)

RESOLVED FIXED in mozilla15

Status

()

Core
js-ctypes
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

unspecified
mozilla15
All
Windows XP
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Created attachment 617442 [details] [diff] [review]
Exporting Windows constants to JS

Companion for bug 739740, but for Windows constants, in particular Windows error values.
Blocks: 707681
Attachment #617442 - Flags: review?(khuey)
Comment on attachment 617442 [details] [diff] [review]
Exporting Windows constants to JS

Review of attachment 617442 [details] [diff] [review]:
-----------------------------------------------------------------

This looks mostly fine, but I'd like to look at it again after you fix the other patch.

::: dom/system/OSFileConstants.cpp
@@ +10,5 @@
>  #include "unistd.h"
>  #endif // defined(XP_UNIX)
>  
> +#if defined(XP_WIN)
> +#include "windows.h"

<windows.h> is the typical style.
Attachment #617442 - Flags: review?(khuey)
Created attachment 618201 [details] [diff] [review]
Exporting Windows constants to JS
Assignee: nobody → dteller
Attachment #617442 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #618201 - Flags: review?(khuey)
Blocks: 750177
Depends on: 739740
Summary: Windows constants for js-ctypes → Windows constants for js-ctypes (Chrome Workers)
Blocks: 750178
OS: Mac OS X → Windows XP
Hardware: x86 → All
Attachment #618201 - Flags: review?(khuey) → review+
Created attachment 622328 [details] [diff] [review]
Exporting Windows constants to JS
Attachment #618201 - Attachment is obsolete: true
Severity: normal → enhancement
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfeab3d52e14
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
http://mozillamemes.tumblr.com/post/21637966463/yes-i-have-a-condition-that-forces-me-to-insert

...and backed out for Win64 bustage (so far, anyway).
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf8b1f792ce

e:/builds/moz2_slave/m-in-w64/build/dom/system/OSFileConstants.cpp(220) : error C2065: 'INVALID_FILE_HANDLE' : undeclared identifier
Target Milestone: mozilla15 → ---
Created attachment 622753 [details] [diff] [review]
Exporting Windows constants to JS

Ok Yoric, take a breath, stop using three distinct local repositories, concentrate and stop uploading crap to the nice sheriffs.

Sorry, Ryan.
Attachment #622328 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/94cab3afbf9b
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/94cab3afbf9b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 754795
You need to log in before you can comment on or make changes to this bug.