Last Comment Bug 747872 - Windows constants for js-ctypes (Chrome Workers)
: Windows constants for js-ctypes (Chrome Workers)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: js-ctypes (show other bugs)
: unspecified
: All Windows XP
: -- enhancement (vote)
: mozilla15
Assigned To: David Rajchenbach-Teller [:Yoric] (please use "needinfo")
:
Mentors:
Depends on: 739740 754795
Blocks: 750177 707681 750178
  Show dependency treegraph
 
Reported: 2012-04-23 03:35 PDT by David Rajchenbach-Teller [:Yoric] (please use "needinfo")
Modified: 2012-05-14 02:47 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Exporting Windows constants to JS (3.43 KB, patch)
2012-04-23 03:35 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
no flags Details | Diff | Splinter Review
Exporting Windows constants to JS (3.49 KB, patch)
2012-04-25 03:04 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
khuey: review+
Details | Diff | Splinter Review
Exporting Windows constants to JS (3.67 KB, patch)
2012-05-09 03:05 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
no flags Details | Diff | Splinter Review
Exporting Windows constants to JS (3.68 KB, patch)
2012-05-10 09:14 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
no flags Details | Diff | Splinter Review

Description David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-04-23 03:35:54 PDT
Created attachment 617442 [details] [diff] [review]
Exporting Windows constants to JS

Companion for bug 739740, but for Windows constants, in particular Windows error values.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-04-24 06:38:51 PDT
Comment on attachment 617442 [details] [diff] [review]
Exporting Windows constants to JS

Review of attachment 617442 [details] [diff] [review]:
-----------------------------------------------------------------

This looks mostly fine, but I'd like to look at it again after you fix the other patch.

::: dom/system/OSFileConstants.cpp
@@ +10,5 @@
>  #include "unistd.h"
>  #endif // defined(XP_UNIX)
>  
> +#if defined(XP_WIN)
> +#include "windows.h"

<windows.h> is the typical style.
Comment 2 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-04-25 03:04:24 PDT
Created attachment 618201 [details] [diff] [review]
Exporting Windows constants to JS
Comment 3 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-05-09 03:05:46 PDT
Created attachment 622328 [details] [diff] [review]
Exporting Windows constants to JS
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-09 16:03:03 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfeab3d52e14
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-05-09 16:31:13 PDT
http://mozillamemes.tumblr.com/post/21637966463/yes-i-have-a-condition-that-forces-me-to-insert

...and backed out for Win64 bustage (so far, anyway).
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf8b1f792ce

e:/builds/moz2_slave/m-in-w64/build/dom/system/OSFileConstants.cpp(220) : error C2065: 'INVALID_FILE_HANDLE' : undeclared identifier
Comment 6 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-05-10 09:14:13 PDT
Created attachment 622753 [details] [diff] [review]
Exporting Windows constants to JS

Ok Yoric, take a breath, stop using three distinct local repositories, concentrate and stop uploading crap to the nice sheriffs.

Sorry, Ryan.
Comment 8 Matt Brubeck (:mbrubeck) 2012-05-13 17:40:38 PDT
https://hg.mozilla.org/mozilla-central/rev/94cab3afbf9b

Note You need to log in before you can comment on or make changes to this bug.