748379 - xulrunner builds broken by "webapprt: No such file or directory"

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Mac and Windows xulrunner builds are broken with the error "webapprt: No such file or directory":

<https://tbpl.mozilla.org/?rev=21da3f655b30&noignore=1>:

/bin/sh: line 0: cd: universal/xulrunner/XUL.framework/Versions/Current/webapprt: No such file or directory
- <https://tbpl.mozilla.org/php/getParsedLog.php?id=11150844&tree=Firefox&full=1#error0>

/bin/sh: line 0: cd: xulrunner/webapprt: No such file or directory
- <https://tbpl.mozilla.org/php/getParsedLog.php?id=11151235&tree=Firefox&full=1#error0>

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: only enable the runtime for Firefox

1. configure.in enables the runtime for Windows and Mac by defining MOZ_WEBAPP_RUNTIME for those target OSes;

    case "${target}" in
    *darwin*)
        ACCESSIBILITY=
        MOZ_WEBAPP_RUNTIME=1
        ;;
    *)
        ACCESSIBILITY=1
        ;;
    esac
    
    case "$target_os" in
        mingw*)
            NS_ENABLE_TSF=1
            AC_DEFINE(NS_ENABLE_TSF)
            MOZ_WEBAPP_RUNTIME=1
            ;;
    esac

2. only Firefox builds webapprt/ (via its browser/build.mk);

    ifdef MOZ_WEBAPP_RUNTIME
    tier_app_dirs += webapprt
    endif

3. toolkit/mozapps/installer/packager.mk tries to package the runtime if MOZ_WEBAPP_RUNTIME is defined, regardless of what was built;

4. `make package` fails for XULRunner because webapprt/ wasn't built.


The solution seems obvious: only enable the runtime for Firefox.  We could test for MOZ_BUILD_APP=browser in configure.in, but project-specific defines are what confvars.sh is for.  Here's a patch.  Tryserver run:

https://tbpl.mozilla.org/?tree=Try&noignore=1&rev=cd8a979582d2


Dave: the changes are in configure.in and browser/confvars.sh.  Are you ok to review this, or should I get a Build Config peer like bsmedberg to review it?

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 618053 [details] [diff] [review]
patch v1: only enable the runtime for Firefox

I don't think anyone else needs to look at this.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 618053 [details] [diff] [review]
patch v1: only enable the runtime for Firefox

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd0ea13a52bb

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cd0ea13a52bb

Comment 5

[Simon Kornblith]

Can this be merged to Aurora?

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 618053 [details] [diff] [review]
patch v1: only enable the runtime for Firefox

[Approval Request Comment]
Regression caused by (bug #): Bug 746156
User impact if declined: No XULRunner builds on OSX and Windows for XULRunner 14
Testing completed (on m-c, etc.): On m-c for a few days, builds complete successfully
Risk to taking this patch (and alternatives if risky): None I think
String changes made by this patch: None

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

approval-mozilla-aurora+=me 
low/no known risk, and getting xulrunner builds for 14 seems pretty useful.

Comment 8

[Dave Townsend [:mossop]]

fixed on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/ef9cb1276f4c

Comment 9

[Jason Smith [:jsmith]]

Myk - Trying to figure out what I need to verify here - Could you clarify?

Comment 10

[Myk Melez [:myk] [@mykmelez]]

I don't think there's anything to verify here, except possibly that XULRunner nightly builds are no longer busted (at least not for this reason):

https://tbpl.mozilla.org/?noignore=1&rev=ac968ff4fe41