749022 - Developer info request replies should occur within site

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Justin Scott [:fligtar]]

When an editor requests more info from a developer during the review, the email should contain a link that allows the dev to submit a reply that appears in the review history log.

While an add-on/app is waiting for a developer reply, it should have a special icon in the queue indicating it's waiting on the dev. When the developer has replied, that icon can either disappear or become one indicating the dev has replied.

The primary use of this feature is editors asking for test account information from the dev, so it's good for it to be directly in the review log for future reviewers.

Comment 1

[Wil Clouser [:clouserw]]

I thought we replaced this feature with emails going to the mailing list.  Jorge: do you remember why we got rid of this feature?  I think we tried to do a complicated threading model?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

If memory serves me right, it was dropped during the zamboni port because it was a low priority feature which was a bit disconnected from the rest of the review tools. Asking devs to email us instead works OK, but it's less than ideal.

Restoring the feature to its previous form is fine IMO.

Comment 3

[Andrew Williamson [:eviljeff]]

(I concur with Jorge's memory recall)

The other issue with the Remora implementation was the notification for replies only got sent to the editor who requested it so editors who contributed irregularly would ignore it and the reply could be missed.  This could be addressed by having a 'replied-to' flag in the review queue so we'd know to look.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

This is an excellent idea.

In response to comment 2 and comment 3, we could solve this two ways:

1) easy way: include only a link to the web page where the developer/reviewer can reply
2) hard-but-amazing way: do it the GitHub™ way have the Reply-To be some email bot that actually POSTS the responses to a web service that saves the responses in the database

Comment 5

[Wil Clouser [:clouserw]]

#2 is exactly what commbadge is which should also solve this bug, so I'm going to close it in favor of that larger (and already almost done) project.  See bug 855776 for details.

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to Wil Clouser [:clouserw] from comment #5)
> #2 is exactly what commbadge is which should also solve this bug, so I'm
> going to close it in favor of that larger (and already almost done) project.
> See bug 855776 for details.
> 
> *** This bug has been marked as a duplicate of bug 855776 ***

Is the work in bug 855776 being ported to AMO?  This bug was the AMO specific implementation, 855776 for Marketplace.

Comment 7

[Wil Clouser [:clouserw]]

Ah, I see.  I assume it would work in both, but will reopen just in case.  If nothing else, for anyone following this bug, you'll want to look at that other bug also.

Comment 8

[Wladimir Palant]

At the very least, the text in the "request info" form needs to change - currently it claims that developers will be able to reply and the reviewer will be notified. This is very misleading.