Try server emails for try-comm-central include the wrong links

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
7 years ago
6 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildbot][thunderbird][try])

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Just got an email for try-comm-central, in the email, the links to the changeset and to tbpl are wrong:

==== Email extract ===
Thanks for your try submission (http://hg.mozilla.org/try/pushloghtml?changeset=e40445df7e48).  It's the best!

Watch https://tbpl.mozilla.org/?tree=Try&rev=e40445df7e48 for your results to come in.
==== End Email extract ====

They should have been:

http://hg.mozilla.org/try-comm-central/pushloghtml?changeset=e40445df7e48

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e40445df7e48

Updated

7 years ago
Priority: -- → P3
Whiteboard: [buildbot][thunderbird][try]
Blocks: 750461
No longer blocks: 698843
Created attachment 619669 [details] [diff] [review]
work-in-progress patch
I just hit this one... jhopkins: how's the patch going?

Gerv
jhopkins: ping?

Gerv
(Assignee)

Comment 4

6 years ago
Created attachment 659643 [details] [diff] [review]
Fix the trymailer

Untested, but I think this should work as long as I've got how to get the branch name correct in both cases.
Attachment #659643 - Flags: review?(bhearsum)
(Assignee)

Updated

6 years ago
Attachment #619669 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
Created attachment 659645 [details] [diff] [review]
Fix --post-to-bugzilla annotations

This should fix the --post-to-bugzilla notifications.
Attachment #659645 - Flags: review?(bhearsum)
Comment on attachment 659643 [details] [diff] [review]
Fix the trymailer

Review of attachment 659643 [details] [diff] [review]:
-----------------------------------------------------------------

::: bin/try_mailer.py
@@ +63,5 @@
>  
> +    branch = props['branch']
> +    tree = "Try"
> +    if 'comm' in branch:
> +       tree = "ThunderbirdTry" 

I don't like the hardcoding of the tree name here. I can't bring myself to r- based on it, but I filed bug 789935 to fix it later.
Attachment #659643 - Flags: review?(bhearsum) → review+
Comment on attachment 659645 [details] [diff] [review]
Fix --post-to-bugzilla annotations

Review of attachment 659645 [details] [diff] [review]:
-----------------------------------------------------------------

Lukas/RelMan owns this code, I don't feel comfortable reviewing it.
Attachment #659645 - Flags: review?(bhearsum) → review?(lsblakk)
(Assignee)

Comment 9

6 years ago
Created attachment 659997 [details] [diff] [review]
ThunderbirdTry -> Thunderbird-Try

Stupid typo, we had the forms without the dash before we moved across to the FF infra, and it still catches me out :-(
Attachment #659997 - Flags: review?(bhearsum)
(Assignee)

Comment 10

6 years ago
Created attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

Corrected for Thunderbird-Try
Attachment #659645 - Attachment is obsolete: true
Attachment #659645 - Flags: review?(lsblakk)
Attachment #659998 - Flags: review?(lsblakk)
Comment on attachment 659997 [details] [diff] [review]
ThunderbirdTry -> Thunderbird-Try

I happened to peek in, and simple enough to steal from ben
Attachment #659997 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → mbanner
(Assignee)

Comment 12

6 years ago
Comment on attachment 659997 [details] [diff] [review]
ThunderbirdTry -> Thunderbird-Try

http://hg.mozilla.org/build/buildbotcustom/rev/471d9c4437ea
Attachment #659997 - Flags: checked-in+
In production.
(Assignee)

Updated

6 years ago
Attachment #659998 - Attachment is patch: true
(Assignee)

Updated

6 years ago
Whiteboard: [buildbot][thunderbird][try] → [buildbot][thunderbird][try][try emails fixed, post to bugzilla patch pending review]
Comment on attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

This patch looks good to me.
Attachment #659998 - Flags: feedback+
Comment on attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

There's no staging schedulerdbpoller, but this looks ok so rubber-stamp r+ and we can land/test, backout if it blows up the --post-to-bugzilla.
Attachment #659998 - Flags: review?(lsblakk) → review+
(Assignee)

Comment 16

6 years ago
Comment on attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

Checked in to default and production:

http://hg.mozilla.org/build/autoland/rev/ca5d3af358d6
http://hg.mozilla.org/build/autoland/rev/f7759f0ce3a7
Attachment #659998 - Flags: checked-in+
Pulled onto autoland master, so we should see this reflected in future bug posts.
(Assignee)

Comment 18

6 years ago
So this didn't work. My current theory is that this is because autoland is being called with "Try" as the branch argument. I think that is in turn because of bug 734225 - some of the Thunderbird builds are showing up on autoland.

Lukas, do you know if autoland explicitly watches the "try" branch for --post-to-bugzilla? As that would confirm my thinking.
Depends on: 734225
(Assignee)

Updated

6 years ago
Blocks: 807778
(Assignee)

Comment 19

6 years ago
As the try server emails have now been fixed, which is what this bug was originally about, I'm going to mark this as fixed.

I've split off the autoland/--post-to-bugzilla issues into bug 807778.

(fwiw in comment 18, bug 734225 should have been bug 751066)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
No longer depends on: 734225
Resolution: --- → FIXED
Whiteboard: [buildbot][thunderbird][try][try emails fixed, post to bugzilla patch pending review] → [buildbot][thunderbird][try]
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.