749151 - Try server emails for try-comm-central include the wrong links

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Mark Banner (:standard8)]

Just got an email for try-comm-central, in the email, the links to the changeset and to tbpl are wrong:

==== Email extract ===
Thanks for your try submission (http://hg.mozilla.org/try/pushloghtml?changeset=e40445df7e48).  It's the best!

Watch https://tbpl.mozilla.org/?tree=Try&rev=e40445df7e48 for your results to come in.
==== End Email extract ====

They should have been:

http://hg.mozilla.org/try-comm-central/pushloghtml?changeset=e40445df7e48

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=e40445df7e48

Comment 1

[John Hopkins (:jhopkins)]

Attachment: work-in-progress patch

Comment 2

[Gervase Markham [:gerv]]

I just hit this one... jhopkins: how's the patch going?

Gerv

Comment 3

[Gervase Markham [:gerv]]

jhopkins: ping?

Gerv

Comment 4

[Mark Banner (:standard8)]

Attachment: Fix the trymailer

Untested, but I think this should work as long as I've got how to get the branch name correct in both cases.

Comment 5

[Mark Banner (:standard8)]

Attachment: Fix --post-to-bugzilla annotations

This should fix the --post-to-bugzilla notifications.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 659643 [details] [diff] [review]
Fix the trymailer

Review of attachment 659643 [details] [diff] [review]:
-----------------------------------------------------------------

::: bin/try_mailer.py
@@ +63,5 @@
>  
> +    branch = props['branch']
> +    tree = "Try"
> +    if 'comm' in branch:
> +       tree = "ThunderbirdTry" 

I don't like the hardcoding of the tree name here. I can't bring myself to r- based on it, but I filed bug 789935 to fix it later.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 659645 [details] [diff] [review]
Fix --post-to-bugzilla annotations

Review of attachment 659645 [details] [diff] [review]:
-----------------------------------------------------------------

Lukas/RelMan owns this code, I don't feel comfortable reviewing it.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 659643 [details] [diff] [review]
Fix the trymailer

http://hg.mozilla.org/build/buildbotcustom/rev/ad06bd5973ce

Comment 9

[Mark Banner (:standard8)]

Attachment: ThunderbirdTry -> Thunderbird-Try

Stupid typo, we had the forms without the dash before we moved across to the FF infra, and it still catches me out :-(

Comment 10

[Mark Banner (:standard8)]

Attachment: Fix --post-to-bugzilla annotations v2

Corrected for Thunderbird-Try

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 659997 [details] [diff] [review]
ThunderbirdTry -> Thunderbird-Try

I happened to peek in, and simple enough to steal from ben

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 659997 [details] [diff] [review]
ThunderbirdTry -> Thunderbird-Try

http://hg.mozilla.org/build/buildbotcustom/rev/471d9c4437ea

Comment 13

[Kim Moir [:kmoir] ET]

In production.

Comment 14

[John Hopkins (:jhopkins)]

Comment on attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

This patch looks good to me.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

There's no staging schedulerdbpoller, but this looks ok so rubber-stamp r+ and we can land/test, backout if it blows up the --post-to-bugzilla.

Comment 16

[Mark Banner (:standard8)]

Comment on attachment 659998 [details] [diff] [review]
Fix --post-to-bugzilla annotations v2

Checked in to default and production:

http://hg.mozilla.org/build/autoland/rev/ca5d3af358d6
http://hg.mozilla.org/build/autoland/rev/f7759f0ce3a7

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Pulled onto autoland master, so we should see this reflected in future bug posts.

Comment 18

[Mark Banner (:standard8)]

So this didn't work. My current theory is that this is because autoland is being called with "Try" as the branch argument. I think that is in turn because of bug 734225 - some of the Thunderbird builds are showing up on autoland.

Lukas, do you know if autoland explicitly watches the "try" branch for --post-to-bugzilla? As that would confirm my thinking.

Comment 19

[Mark Banner (:standard8)]

As the try server emails have now been fixed, which is what this bug was originally about, I'm going to mark this as fixed.

I've split off the autoland/--post-to-bugzilla issues into bug 807778.

(fwiw in comment 18, bug 734225 should have been bug 751066)