Tracking potential leaks in the SDK exposed by bug 695480

RESOLVED FIXED

Status

Add-on SDK
General
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: KWierso, Assigned: ochameau)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 618931 [details]
cfx testall's log

So I cfx testall'd the current master branch of the SDK and against an hourly build of Firefox that included bug 695480.

Attached is the results of the cfx testall. 
There are 83 counts of "can't access dead object", which was introduced in bug 695480 and is thrown when code tries to reach an object that no longer exists because of the patch.
Alex, could you take a look and figure out what is going on here? This suggests to me that objects that were somehow leaking before are now getting deleted, but I'd expect if we're actually using those objects that we'd see far more test failures than we have.

Would be nice to have some idea by the meeting tomorrow, but not critical.
Assignee: nobody → poirot.alex
(Assignee)

Updated

5 years ago
Depends on: 751211
(Assignee)

Updated

5 years ago
Depends on: 751546
(Assignee)

Updated

5 years ago
Depends on: 751584
(Assignee)

Updated

5 years ago
Depends on: 751595
(Reporter)

Updated

5 years ago
Priority: -- → P4
Summary: Leaks in the SDK exposed by bug 695480 → Tracking potential leaks in the SDK exposed by bug 695480
Bug 751420 comment 12 is an explanation of what's going on.

Is it possible to get a list of all the add-ons on AMO built with old versions of the SDK?
(In reply to Nicholas Nethercote [:njn] from comment #2)
> Bug 751420 comment 12 is an explanation of what's going on.
> 
> Is it possible to get a list of all the add-ons on AMO built with old
> versions of the SDK?

The AMO guys have that info
(Assignee)

Comment 4

5 years ago
In bug 751211, we were potentially leaking Panel/Page-Worker/Widget document on addon disabling.
In bug 751546, tab `select` may not be firing.
In bug 751595, I don't think any addon is going to face this one. It was triggered only on documents being destroyed before Symbiont object is inited.

The worse case is bug 751420 where content document matched by page-mod or targeted with tab.attach() are going to be leaked!
I wrote more details in bug 751420 comment 19.
See bug 751466 for potential solutions about these leaks.
Depends on: 751420
(Reporter)

Updated

5 years ago
OS: Windows 8 → All
Hardware: x86_64 → All
Can we close this bug?  All the dependent bugs have been closed.
There was another one in the last few days that maybe should be blocking this.  I don't recall the number unfortunately...
Depends on: 752468
(Assignee)

Comment 7

5 years ago
I think that the last one was figured out, so closing it now.
But do not hesitate to reopen if there is one left.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.