751584 - "can't access dead object" exception in api-utis/namescape:handle()

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

This exception is happening during the end of api-utils tests:
error: An exception occurred.
Traceback (most recent call last):
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/timer.js", line 28, in notify
    callback.apply(null, args);
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/test-harness/lib/harness.js", line 185, in cleanup
    unload(loader);
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/cuddlefish.js", line 319, in unload
    observerService.notifyObservers(null, loader.unloadTopic, reason);
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/system/events.js", line 58, in 
    data: data
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/unload.js", line 59, in unload
    observers.forEach(function(observer) {
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/unload.js", line 61, in 
    observer(reason);
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/observer-service.js", line 125, in 
    cache.slice().forEach(function(callback) {
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/observer-service.js", line 126, in 
    Object.keys(subscribers(callback)).forEach(function(topic) {
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/namespace.js", line 35, in namespace
    let key = handle(target);
  File "resource://0a7d8cb0-0a98-487b-8c23-7cb88be580f3-at-jetpack/api-utils/lib/namespace.js", line 13, in handle
    return target[handle.key] || Object.defineProperty(target, handle.key, {
TypeError: can't access dead object

You can find an example here:
  https://tbpl.mozilla.org/php/getParsedLog.php?id=11397108&tree=Jetpack

Comment 1

[Alexandre Poirot [:ochameau]]

Irakli, Would you have time to take a look at this one?
That would be the last visible one in our tests.
(after all others I've submitted patch for)

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/429

Pointer to Github pull-request

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 620966 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/429

Can you ensure that landing a breaking change for FF12 is ok?
The platform fix (bug 673468) landed only for FF13+.
The dev branch of the SDK should currently be the one for 1.8, which is, I think, aiming to support FF13+.
But install.rdf and SDK release schedule still says that current FF support is 12+:
https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/app-extension/install.rdf
https://wiki.mozilla.org/Jetpack/SDK_2012_Release_Schedule

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Alexandre Poirot (:ochameau) from comment #3)
> Comment on attachment 620966 [details]
> Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/429
> 
> Can you ensure that landing a breaking change for FF12 is ok?

Why is this breaking change ? With this change everything works for me on FF12. Are you sure that fix for bug 673468 was not shipped in FF12 ?

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8786e2f2891279b5c0e128159fa538dfb4a45d04
Merge pull request #429 from Gozala/bug/ns-workarounds@751584

fix Bug 751584 - Removing workarounds for bug 673468 r=@ochameau