Closed
Bug 749573
Opened 13 years ago
Closed 13 years ago
"make install" doesn't install xpcshell and run-mozilla.sh in the SDK
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox12 unaffected, firefox13 unaffected, firefox14 fixed)
RESOLVED
FIXED
mozilla15
| Tracking | Status | |
|---|---|---|
| firefox12 | --- | unaffected |
| firefox13 | --- | unaffected |
| firefox14 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
ted
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
bug 743560 made them part of the SDK instead of xulrunner. make make-sdk ships them, but make install doesn't.
As a side note, run-mozilla.sh is not shipped in xulrunner, maybe it shouldn't be shipped in Firefox either.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #618992 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•13 years ago
|
status-firefox12:
--- → unaffected
status-firefox13:
--- → unaffected
status-firefox14:
--- → affected
|
||
Updated•13 years ago
|
Attachment #618992 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla15
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 618992 [details] [diff] [review]
Declare run-mozilla.sh and xpcshell as SDK_BINARY
[Approval Request Comment]
Regression caused by: bug 743560
User impact if declined: People using make install (mostly, Linux distros) won't have run-mozilla.sh and xpcshell installed with SDK.
Testing completed (on m-c, etc.): Landed on m-c a couple days ago.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.
Attachment #618992 -
Flags: approval-mozilla-aurora?
|
||
Comment 5•13 years ago
|
||
Comment on attachment 618992 [details] [diff] [review]
Declare run-mozilla.sh and xpcshell as SDK_BINARY
[Triage Comment]
Low risk fix in support of local builds.
Attachment #618992 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•